Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osl_get_attribute() should use device strings when compiling for OptiX. #1435

Merged

Conversation

cmstein
Copy link
Collaborator

@cmstein cmstein commented Nov 17, 2021

Description

OSL will call osl_get_attribute() with device strings (ustring hashes) when compiling for the GPU (like osl_printf()).

Tests

No changes to testsuite. Works locally in our renderer.

Checklist:

  • I have read the contribution guidelines.
  • I have previously submitted a Contributor License Agreement.
  • I have updated the documentation, if applicable.
  • I have ensured that the change is tested somewhere in the testsuite (adding new test cases if necessary).
  • My code follows the prevailing code style of this project.

@cmstein cmstein force-pushed the gpu_osl_getattribute_fix branch from d18af3d to 39f28c9 Compare November 17, 2021 18:35
@lgritz lgritz merged commit 1ff9aec into AcademySoftwareFoundation:main Nov 17, 2021
@lgritz
Copy link
Collaborator

lgritz commented Nov 17, 2021

Cliff, do you need a new internal release with this right away?

@cmstein
Copy link
Collaborator Author

cmstein commented Nov 17, 2021

Yeah, that'd be helpful. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants