Removing race condition when compiling for OptiX 7 #1411
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes a race condition when compiling PTX device code in a multithreaded environment.
The problems stems from OptiX6 requiring the
rend_lib.cu
device bitcode to be linked to each compiled shadergroup whereas we only need to link therend_lib.cu
device bitcode to one shadergroup in OptiX7. When I added OptiX7 support, I put a static/global in OSL to ensure that we don't get multiple definitions fromrend_lib.cu
in the device code for OptiX7. But that's a poor solution for a couple of reasons:This removes the requirement to supply the
rend_lib.cu
device code when using OptiX7. But that also means the renderer now needs to manually link it in. Bothtestshade
andtestrender
have been updated to reflect this.Tests
testsuite runs the same with this fix
Checklist: