Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix color conversion from RGB to xyY #1410

Merged
merged 3 commits into from Sep 23, 2021
Merged

Fix color conversion from RGB to xyY #1410

merged 3 commits into from Sep 23, 2021

Conversation

ix-bruiz
Copy link
Contributor

Description

Fix color conversion from RGB to xyY space.

Tests

Added testcase for xyY conversion in transformc testsuite.

Checklist:

  • I have read the contribution guidelines.
  • I have previously submitted a Contributor License Agreement.
  • I have updated the documentation, if applicable.
  • I have ensured that the change is tested somewhere in the testsuite (adding new test cases if necessary).
  • My code follows the prevailing code style of this project.

@lgritz
Copy link
Collaborator

lgritz commented Sep 22, 2021

I believe this need an update of test reference output.

@ix-bruiz
Copy link
Contributor Author

ix-bruiz commented Sep 23, 2021

Indeed! Didn't notice it wasn't automatically updated! Should be good now.

By the way, it was pretty hard to make the test system work on windows (I didn't try it on Linux), and we had to dig pretty deeply into it to understand how everything was setup (and fix the windows related issues). We'll make a PR to fix this on Windows, but it would also be great to have a small documentation on how to properly contribute to the tests (maybe this already exists, but I couldn't find it).

@ix-bruiz
Copy link
Contributor Author

I also pushed a fix regarding test compilation on Windows, where casting nullptr to intptr_t is invalid.

Copy link
Collaborator

@lgritz lgritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@lgritz lgritz merged commit 3f87e75 into AcademySoftwareFoundation:master Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants