Build: collapse build and dist hierarchy #1396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to a recent change in OIIO... For historical reasons, our wrapper makefiles assume that we build in `build/ARCH[.variant]`, so maybe build/linux64, build/linux64.debug, etc. Get rid of this extra bit of hierarchy, it no longer serves us and it's contrary to modern cmake practice. Also used this as an excuse to remove some SPI build script customization that we no longer use. Signed-off-by: Larry Gritz <[email protected]>
|
Any objections to this? I think it only affects people who are fond of the "Makefile wrapper". People used to typing raw cmake commands to build OSL should see no difference. |
aconty
approved these changes
Aug 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to a recent change in OIIO... For historical reasons, our
wrapper makefiles assume that we build in
build/ARCH[.variant], somaybe build/linux64, build/linux64.debug, etc.
Get rid of this extra bit of hierarchy, it no longer serves us and
it's contrary to modern cmake practice.
Also used this as an excuse to remove some SPI build script
customization that we no longer use.
Signed-off-by: Larry Gritz [email protected]