Build: be robust to certain OpenEXR 2.x config files #1356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ever since adding OpenEXR 3.0 support, we had some cases where installations that built the 2.x IlmBase and OpenEXR portions separately and installing to separate areas, had trouble being found properly. Remove the need to include OpenEXR/OpenEXRConfig.h Also make some minor changes to ci.yml to make sure we are documenting the right openexr versions used for each test. Signed-off-by: Larry Gritz <[email protected]>
Signed-off-by: Larry Gritz <[email protected]>
lgritz
added a commit
to lgritz/OpenShadingLanguage
that referenced
this pull request
Apr 19, 2021
…Foundation#1356) Ever since adding OpenEXR 3.0 support, we had some cases where installations that built the 2.x IlmBase and OpenEXR portions separately and installing to separate areas, had trouble being found properly. Remove the need to include OpenEXR/OpenEXRConfig.h Also make some minor changes to ci.yml to make sure we are documenting the right openexr versions used for each test. Signed-off-by: Larry Gritz <[email protected]>
lgritz
added a commit
to lgritz/OpenShadingLanguage
that referenced
this pull request
Apr 19, 2021
…Foundation#1356) Ever since adding OpenEXR 3.0 support, we had some cases where installations that built the 2.x IlmBase and OpenEXR portions separately and installing to separate areas, had trouble being found properly. Remove the need to include OpenEXR/OpenEXRConfig.h Also make some minor changes to ci.yml to make sure we are documenting the right openexr versions used for each test. Signed-off-by: Larry Gritz <[email protected]>
lgritz
added a commit
to lgritz/OpenShadingLanguage
that referenced
this pull request
Apr 19, 2021
…Foundation#1356) Ever since adding OpenEXR 3.0 support, we had some cases where installations that built the 2.x IlmBase and OpenEXR portions separately and installing to separate areas, had trouble being found properly. Remove the need to include OpenEXR/OpenEXRConfig.h Also make some minor changes to ci.yml to make sure we are documenting the right openexr versions used for each test. Fix wrong oiio used for oldest tests. Signed-off-by: Larry Gritz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ever since adding OpenEXR 3.0 support, we had some cases where
installations that built the 2.x IlmBase and OpenEXR portions
separately and installing to separate areas, had trouble being found
properly.
Remove the need to include OpenEXR/OpenEXRConfig.h
Also make some minor changes to ci.yml to make sure we are documenting
the right openexr versions used for each test.
Signed-off-by: Larry Gritz [email protected]