Typo prevented visibility hiding from happening properly #1337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Larry Gritz <[email protected]>
|
Thanks Larry, LGTM. |
johnhaddon
added a commit
to johnhaddon/dependencies
that referenced
this pull request
Feb 18, 2021
From AcademySoftwareFoundation/OpenShadingLanguage#1337. This fixes conflicts with the system LLVM loaded by the Mesa driver.
johnhaddon
added a commit
to johnhaddon/dependencies
that referenced
this pull request
Feb 18, 2021
From AcademySoftwareFoundation/OpenShadingLanguage#1337. This fixes conflicts with the system LLVM loaded by the Mesa driver. It also means we can remove the Appleseed patch that was working around conflicts between liboslexec and liboslcomp. The first of many wrong trees I barked up until finding the problem in OSL.
lgritz
added a commit
to lgritz/OpenShadingLanguage
that referenced
this pull request
Feb 18, 2021
…wareFoundation#1337) Signed-off-by: Larry Gritz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1336
Signed-off-by: Larry Gritz [email protected]