Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Symbol and Opcode changes to support batched analysis #1313

Merged
merged 5 commits into from
Dec 9, 2020
Merged

Symbol and Opcode changes to support batched analysis #1313

merged 5 commits into from
Dec 9, 2020

Conversation

AlexMWells
Copy link
Contributor

@AlexMWells AlexMWells commented Dec 8, 2020 •
edited
Loading

During batched analysis we will be figuring out which symbols need to be varying and which can be uniform during batched execution, we will also be figuring out the minimum number of operations which require masking as well as storing/caching some other operation specific flags used later in batched code generation. We choose to store these analysis results inside Symbol and Opcode directly so that they are efficiently accessible and stable under optimization passes than might invalidate OpcodeVec.

Description

Tests

Checklist:

  • I have read the contribution guidelines.
  • I have previously submitted a Contributor License Agreement.
  • I have updated the documentation, if applicable.
  • I have ensured that the change is tested somewhere in the testsuite (adding new test cases if necessary).
  • My code follows the prevailing code style of this project.

@AlexMWells
During batched analysis we will be figuring out which symbols need to…
9eabbba 
… be varying and which can be uniform during batched execution, we will also be figuring out the minimum number of operations which require masking as well as storing/caching some other operation specific flags used later in batched code generation. We choose to store these analysis results inside Symbol and Opcode directly so that they are efficiently accessible and stable under optimization passes than might invidate OpcodeVec.
@AlexMWells
Added Symbol::is_varying() convenience method to improve readability …
d19882c 
…vs. (sym->is_uniform() == false)
@AlexMWells
Fix unitialized m_analysis_flag compiler warning
b65466a
@AlexMWells
Clang format of osl_pvt.h changes
81d2f90
@AlexMWells
Changed Symbol::require_masking() to Symbol::requires_masking(bool v)
c93a581
lgritz
lgritz approved these changes Dec 9, 2020
View reviewed changes
Copy link
Collaborator

@lgritz lgritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lgritz lgritz merged commit 3104c85 into AcademySoftwareFoundation:master Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgritz lgritz lgritz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexMWells @lgritz