initial commit for simple self-contained cuda example #1280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgritz
reviewed
Oct 31, 2020
| include(check_is_enabled) | ||
| include(checked_find_package) | ||
|
|
||
| find_package(OSL REQUIRED) |
There was a problem hiding this comment.
You can use checked_find_package for all of these
lgritz
approved these changes
Oct 31, 2020
|
I'm ready to merge whenever you let me know you've worked it all out with your company and they are clear with you that this work is covered by the CLA they've already signed. |
|
All is good with the overlords but I'll need to give you an individual CLA.
Where should I email it to?
…On Sun, 1 Nov 2020 at 10:47, Larry Gritz ***@***.***> wrote:
I'm ready to merge whenever you let me know you've worked it all out with
your company and they are clear with you that this work is covered by the
CLA they've already signed.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1280 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOYQXN6G3V4EK75QH4WBFDSNSAXXANCNFSM4S7AL5CQ>
.
|
|
For OSL, email CLAs to [email protected], for OIIO mail to [email protected]. |
|
CLA received. Anders, can you please rebase this on top of the current master and then do a push --force? I think the CI failures are all things unrelated to your change, which have already been fixed. But I'd love to see a fully passed CI so we know there's not a problem lurking in this patch being masked by the other failures. |
add copyright and rename headers to fit project convention remove rend_lib bytecode from build remove optix includes
anderslanglands
force-pushed
the
example-cuda
branch
from
06d4be3 to
7428a12
Compare
|
Done and done. Unfortunately the Appveyor build appears to be failing on
the pugixml build?
…On Fri, 6 Nov 2020 at 19:34, Larry Gritz ***@***.***> wrote:
CLA received.
Anders, can you please rebase this on top of the current master and then
do a push --force? I think the CI failures are all things unrelated to your
change, which have already been fixed. But I'd love to see a fully passed
CI so we know there's not a problem lurking in this patch being masked by
the other failures.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1280 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOYQXJRUU77BQI3RK6NBZ3SOOKI3ANCNFSM4S7AL5CQ>
.
|
|
Don't worry about the appveyor. I should just kill that entirely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a simple, self-contained example as a test case called 'example-cuda'. It's basically just a stripped down version of testshade, wrapped up so that one could copy it out of tree and get it building as a standalone example with minimal changes to the CMakeLists.txt. I'm submitting this as I just started looking at OSL in CUDA recently and this is the example I would have loved to have started from.
This example is pure CUDA rather than OptiX, but I'd like to do a matching OptiX version at some point.
Tests
It is a test :)
Checklist: