Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifications to build against LLVM 11 #1274

Merged
merged 1 commit into from
Oct 27, 2020

Conversation

lgritz
Copy link
Collaborator

@lgritz lgritz commented Oct 19, 2020

Change bleeding edge CI test to use LLVM 11.

A variety of changes were necessary to the code in LLVM_Util:

  • #if guards for differing calls related to VectorType::get(),
    CreateShuffleVector.

  • constant-generating functions now return llvm::Constant* instead of
    llvm::Value*.

  • New wide_constant(width,value) functions for when you want a width other
    than the default vector_width.

  • Renamed llvmVectorGet -> llvm_vector_type to be more symmetric with
    other methds we have.

  • Simplified places that could have made calls to constant(),
    constant_bool(), wide_constant(), llvm_vector_type(), and
    call_function(), but instead did more complex llvm calls by hand.

Signed-off-by: Larry Gritz [email protected]

Copy link
Contributor

@aconty aconty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lgritz
Copy link
Collaborator Author

lgritz commented Oct 19, 2020

@AlexMWells Would love your opinion, especially on the changes I made to llvm_passes.h and elsewhere.

@lgritz
Copy link
Collaborator Author

lgritz commented Oct 21, 2020

@AlexMWells Does this look ok?

Change bleeding edge CI test to use LLVM 11.

A variety of changes were necessary to the code in LLVM_Util:

* `#if` guards for differing calls related to VectorType::get(),
  CreateShuffleVector.

* constant-generating functions now return llvm::Constant* instead of
  llvm::Value*.

* New wide_constant(width,value) functions for when you want a width other
  than the default vector_width.

* Renamed llvmVectorGet -> llvm_vector_type to be more symmetric with
  other methds we have.

* Simplified places that could have made calls to constant(),
  constant_bool(), wide_constant(), llvm_vector_type(), and
  call_function(), but instead did more complex llvm calls by hand.

Signed-off-by: Larry Gritz <[email protected]>
@lgritz lgritz merged commit f0b2809 into AcademySoftwareFoundation:master Oct 27, 2020
@lgritz lgritz deleted the lg-llvm11-ghci branch October 27, 2020 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants