Windows compile fixes #1263
Merged
Windows compile fixes #1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linker errors on MSVC
- Link with Version.lib (system lib) to prevent missing symbols in ClangDriver.lib - Do not define OSL_EXPORTS for oslcomp/oslquery as they should import (not export)
Closed
lgritz
approved these changes
Oct 9, 2020
lgritz
pushed a commit
to lgritz/OpenShadingLanguage
that referenced
this pull request
Oct 9, 2020
* Added OSLEXECPUBLIC attributes to inner classes of LLVM_Util to fix linker errors on MSVC * do not include cxxabi.h on non GNUC platforms * fixed windows linker issues - Link with Version.lib (system lib) to prevent missing symbols in ClangDriver.lib - Do not define OSL_EXPORTS for oslcomp/oslquery as they should import (not export) Co-authored-by: Dieter De Baets <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes various small issues when trying to build OSL on Windows (issue #1261).
Version.lib(system library) to prevent missing symbols inside ClangDriver.Tests
master now compiles better on MSVC.
Still not 100% clean for me (shaders is giving errors) but core is fully functional
Checklist: