Propagate uv scale and offset #1864
Conversation
Exactly the same as AcademySoftwareFoundation#1840 but on the main branch.
| // points if that name can be related to the filename input. | ||
| // NOTE: This is enough to have UDIMs working with ND_gltf_colorimage | ||
| // and ND_UsdUVTexture, so we stop here at this time. | ||
| inputSocket = addInputSocket(name, nodeInput->getType()); |
There was a problem hiding this comment.
Original comment from @kwokcb:
Hi @JGamache-autodesk,
I don't think this is enough and is inconsistent with how other sockets are "published" using _ name> . This would also resolve the issue that you should be able to support different UDIM scale/offsets for > different image inputs -- i.e. there is no guarantee there is only one set of UDIM information.
Reply by @JGamache-autodesk:
We should definitely split the issue, especially since this PR only attempts to fix single image wrappers like those found for glTf, USD, ADSK, Arnold, etc. Image nodes wrapped in simple NodeGraph implementations.
The second part where we support multi-image nodes with multiple UDIM scales should be indeed discussed and implemented correctly, but maybe should not be a showstopper for first fixing ND_UsdUVTexture and ND_gltf_colorimage.
There was a problem hiding this comment.
@kwokcb please advise: Is it a case where I should rework the comment, or is it a case where a fix should only be submitted if it also covers the edge case mentioned in the comment?
|
Just an FYI - I have some work in progress where I'm trying to deprecate the |
|
@ld-kerley @JGamache-autodesk Would you prefer to wait for the upcoming data-driven |
|
@jstone-lucasfilm I think we should close this one as it is definitely not compatible with the goals of @ld-kerley. I will see once the data driven image node lands how much work will be required to have UDIMs working. I already have an evil plan that edits in memory the MaterialX library to add There is currently no UDIM support in USD at this time unless the shader is the native UsdPreviewSurface. So we will need to see what USD currently does for its UDIM workflow and what this requires on the MaterialX side. |
Exactly the same as #1840 but on the main branch.
Fixes #1716
Propagate internally added ports when found inside a NodeGraph implementation of a NodeDef.
Testing:
Run render GLSL tests with the shader write option enabled.
Open build/bin/resources/Materials/TestSuite/stdlib/color_management/filename_cm_test/filename_CM_Test_ps.glsl
See that all three image nodes (bl, bl1, and tr1) have uv_scale and uv_offset uniform parameters
See that both NG_tm_test() and NG_tm_retest() now have scale and offset parameters and that these parameters are passed to the mx_image_color3() function.
See that in main() we use all scale and offset uniform parameters when calling either the NodeGraph functions or the regular image node.