sync: main v2025.1201.3826

.github/copilot-instructions.md

@@ -0,0 +1,11 @@
+On Windows we use msys2 and ucrt64 to compile.
+You need to prefix commands with `C:\msys64\msys2_shell.cmd -defterm -here -no-start -ucrt64 -c`.
+
+Prefix build directories with `cmake-build-`.
+
+The test executable is named `test_sunshine` and will be located inside the `tests` directory within
+the build directory.
+
+The project uses gtest as a test framework.
+
+Always follow the style guidelines defined in .clang-format for c/c++ code.

.github/dependabot.yml

@@ -7,23 +7,29 @@ version: 2
 updates:
   - package-ecosystem: "cargo"
     directory: "/"
+    rebase-strategy: disabled
     schedule:
-      interval: "daily"
-      time: "07:30"
+      interval: "cron"
+      cronjob: "0 1 * * *"
+      timezone: "America/New_York"
     open-pull-requests-limit: 10
 
   - package-ecosystem: "docker"
     directory: "/"
+    rebase-strategy: disabled
     schedule:
-      interval: "daily"
-      time: "08:00"
+      interval: "cron"
+      cronjob: "30 1 * * *"
+      timezone: "America/New_York"
     open-pull-requests-limit: 10
 
   - package-ecosystem: "github-actions"
     directory: "/"
+    rebase-strategy: disabled
     schedule:
-      interval: "daily"
-      time: "08:30"
+      interval: "cron"
+      cronjob: "0 2 * * *"
+      timezone: "America/New_York"
     open-pull-requests-limit: 10
     groups:
       docker-actions:
@@ -40,11 +46,22 @@ updates:
         patterns:
           - "LizardByte/*"
 
+  - package-ecosystem: "gitsubmodule"
+    directory: "/"
+    rebase-strategy: disabled
+    schedule:
+      interval: "cron"
+      cronjob: "30 2 * * *"
+      timezone: "America/New_York"
+    open-pull-requests-limit: 10
+
   - package-ecosystem: "npm"
     directory: "/"
+    rebase-strategy: disabled
     schedule:
-      interval: "daily"
-      time: "09:00"
+      interval: "cron"
+      cronjob: "0 3 * * *"
+      timezone: "America/New_York"
     open-pull-requests-limit: 10
     groups:
       dev-dependencies:
@@ -53,26 +70,32 @@ updates:
 
   - package-ecosystem: "nuget"
     directory: "/"
+    rebase-strategy: disabled
     schedule:
-      interval: "daily"
-      time: "09:30"
+      interval: "cron"
+      cronjob: "30 3 * * *"
+      timezone: "America/New_York"
     open-pull-requests-limit: 10
 
   - package-ecosystem: "pip"
     directory: "/"
+    rebase-strategy: disabled
     schedule:
-      interval: "daily"
-      time: "10:00"
+      interval: "cron"
+      cronjob: "0 4 * * *"
+      timezone: "America/New_York"
     open-pull-requests-limit: 10
     groups:
       pytest-dependencies:
         applies-to: version-updates
         patterns:
           - "pytest*"
 
-  - package-ecosystem: "gitsubmodule"
+  - package-ecosystem: "rust-toolchain"
     directory: "/"
+    rebase-strategy: disabled
     schedule:
-      interval: "daily"
-      time: "10:30"
-    open-pull-requests-limit: 10
+      interval: "cron"
+      cronjob: "30 4 * * *"
+      timezone: "America/New_York"
+    open-pull-requests-limit: 1

.github/workflows/_release-notifier.yml

@@ -20,4 +20,6 @@ jobs:
     uses: LizardByte/.github/.github/workflows/__call-release-notifier.yml@master
     if: github.repository_owner == 'LizardByte'
     secrets:
+      GH_EMAIL: ${{ secrets.GH_BOT_EMAIL }}
+      GH_NAME: ${{ secrets.GH_BOT_NAME }}
       GH_TOKEN: ${{ secrets.GH_BOT_TOKEN }}

.github/workflows/_update-flathub-repo.yml

@@ -26,4 +26,6 @@ jobs:
     uses: LizardByte/.github/.github/workflows/__call-update-flathub-repo.yml@master
     if: github.repository_owner == 'LizardByte'
     secrets:
+      GH_EMAIL: ${{ secrets.GH_BOT_EMAIL }}
+      GH_NAME: ${{ secrets.GH_BOT_NAME }}
       GH_TOKEN: ${{ secrets.GH_BOT_TOKEN }}

.github/workflows/_update-pacman-repo.yml

@@ -26,4 +26,6 @@ jobs:
     uses: LizardByte/.github/.github/workflows/__call-update-pacman-repo.yml@master
     if: github.repository_owner == 'LizardByte'
     secrets:
+      GH_EMAIL: ${{ secrets.GH_BOT_EMAIL }}
+      GH_NAME: ${{ secrets.GH_BOT_NAME }}
       GH_TOKEN: ${{ secrets.GH_BOT_TOKEN }}

.github/workflows/ci-bundle.yml

@@ -0,0 +1,29 @@
+---
+name: CI-Bundle
+permissions:
+  contents: read
+
+on:
+  workflow_call:
+    secrets:
+      CODECOV_TOKEN:
+        required: false
+
+jobs:
+  bundle_analysis:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v6
+
+      - name: Setup node
+        id: node
+        uses: actions/setup-node@v6
+
+      - name: Install npm dependencies
+        run: npm install
+
+      - name: Build
+        env:
+          CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
+        run: npm run build

.github/workflows/ci-copr.yml

@@ -43,13 +43,16 @@ jobs:
     name: Release
     if:
       github.event_name == 'release' &&
-      startsWith(github.repository, 'LizardByte/')
+      startsWith(github.repository, 'LizardByte/') &&
+      github.event.release.prerelease == true
     needs:
       - call-copr-ci
+    permissions:
+      contents: write
     runs-on: ubuntu-latest
     steps:
       - name: Download build artifacts
-        uses: actions/download-artifact@v4
+        uses: actions/download-artifact@v6
         with:
           path: artifacts
           pattern: build-*
@@ -59,7 +62,7 @@ jobs:
         run: ls -l artifacts
 
       - name: Update GitHub Release
-        uses: LizardByte/actions/actions/release_create@v2025.715.25226
+        uses: LizardByte/actions/actions/release_create@v2025.1028.23217
         with:
           allowUpdates: true
           body: ${{ github.event.release.body }}
@@ -68,5 +71,5 @@ jobs:
           name: ${{ github.event.release.name }}
           prerelease: true
           tag: ${{ github.event.release.tag_name }}
-          token: ${{ secrets.GH_BOT_TOKEN }}
+          token: ${{ secrets.GITHUB_TOKEN }}  # use built-in token to avoid repeating workflow triggers
           virustotal_api_key: ${{ secrets.VIRUSTOTAL_API_KEY }}

.github/workflows/ci-docker.yml

@@ -49,7 +49,7 @@
 
       - name: Find dockerfiles
         id: find
         run: |
           dockerfiles=$(find . -type f -iname "Dockerfile" -o -iname "debian-bookworm.dockerfile")
 
           echo "found dockerfiles: ${dockerfiles}"
@@ -83,7 +83,7 @@
 
       - name: Find dotnet solution file
         id: find_dotnet
         run: |
           solution=$(find . -maxdepth 1 -type f -iname "*.sln")
 
           echo "found solution: ${solution}"
@@ -263,4 +263,3 @@
           cache-from: type=local,src=/tmp/.buildx-cache
           cache-to: type=local,dest=/tmp/.buildx-cache
           no-cache-filters: ${{ steps.prepare.outputs.no_cache_filters }}
-

.github/workflows/ci-flatpak.yml

@@ -18,8 +18,9 @@ jobs:
     name: ${{ matrix.arch }}
     env:
       APP_ID: dev.lizardbyte.app.Sunshine
+      MATRIX_ARCH: ${{ matrix.arch }}
       NODE_VERSION: "20"
-      PLATFORM_VERSION: "23.08"
+      PLATFORM_VERSION: "24.08"
     runs-on: ${{ matrix.runner }}
     strategy:
       fail-fast: false
@@ -30,25 +31,21 @@ jobs:
           - arch: aarch64
             runner: ubuntu-22.04-arm
     steps:
-      - name: Maximize build space
+      - name: More space
         if: matrix.arch == 'x86_64'
-        uses: easimon/maximize-build-space@v10
+        uses: LizardByte/actions/actions/more_space@v2025.1028.23217
         with:
-          root-reserve-mb: 10240
-          remove-dotnet: 'true'
-          remove-android: 'true'
-          remove-haskell: 'true'
-          remove-codeql: 'true'
-          remove-docker-images: 'true'
+          analyze-space-savings: true
+          clean-all: true
 
       - name: Checkout
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6
         with:
           submodules: recursive
 
       - name: Setup node
         id: node
-        uses: actions/setup-node@v4
+        uses: actions/setup-node@v6
         with:
           node-version: ${{ env.NODE_VERSION }}
 
@@ -60,7 +57,7 @@ jobs:
 
       - name: Setup python
         id: python
-        uses: actions/setup-python@v5
+        uses: actions/setup-python@v6
         with:
           python-version: '3.12'
 
@@ -79,9 +76,9 @@ jobs:
 
           sudo su "$(whoami)" -c "flatpak --user install -y flathub \
             org.flatpak.Builder \
-            org.freedesktop.Platform/${{ matrix.arch }}/${PLATFORM_VERSION} \
-            org.freedesktop.Sdk/${{ matrix.arch }}/${PLATFORM_VERSION} \
-            org.freedesktop.Sdk.Extension.node${NODE_VERSION}/${{ matrix.arch }}/${PLATFORM_VERSION} \
+            org.freedesktop.Platform/${MATRIX_ARCH}/${PLATFORM_VERSION} \
+            org.freedesktop.Sdk/${MATRIX_ARCH}/${PLATFORM_VERSION} \
+            org.freedesktop.Sdk.Extension.node${NODE_VERSION}/${MATRIX_ARCH}/${PLATFORM_VERSION} \
           "
 
           flatpak run org.flatpak.Builder --version
@@ -103,23 +100,21 @@ jobs:
 
       - name: Configure Flatpak Manifest
         env:
-          BRANCH: ${{ github.head_ref }}
+          INPUT_RELEASE_VERSION: ${{ inputs.release_version }}
+          INPUT_RELEASE_COMMIT: ${{ inputs.release_commit }}
+          REPOSITORY_CLONE_URL: ${{ github.event.repository.clone_url }}
         run: |
           # variables for manifest
-          branch="${{ env.BRANCH }}"
-          build_version=${{ inputs.release_version }}
-          commit=${{ inputs.release_commit }}
+          branch="${GITHUB_REF}"
+          build_version="${INPUT_RELEASE_VERSION}"
+          commit="${INPUT_RELEASE_COMMIT}"
+          clone_url="${REPOSITORY_CLONE_URL}"
 
-          # check the branch variable
-          if [ -z "$branch" ]
-          then
+          if [ "${GITHUB_EVENT_NAME}" == "push" ]; then
             echo "This is a PUSH event"
-            branch=${{ github.ref_name }}
-            clone_url=${{ github.event.repository.clone_url }}
-          else
-            echo "This is a PR event"
-            clone_url=${{ github.event.pull_request.head.repo.clone_url }}
+            branch="${GITHUB_REF_NAME}"
           fi
+
           echo "Branch: ${branch}"
           echo "Commit: ${commit}"
           echo "Clone URL: ${clone_url}"
@@ -132,7 +127,7 @@ jobs:
           mkdir -p build
           mkdir -p artifacts
 
-          cmake -DGITHUB_CLONE_URL=${clone_url} \
+          cmake -DGITHUB_CLONE_URL="${clone_url}" \
             -B build \
             -S . \
             -DSUNSHINE_CONFIGURE_FLATPAK_MAN=ON \
@@ -147,35 +142,35 @@ jobs:
         run: |
           echo "::add-matcher::.github/matchers/gcc-strip3.json"
           sudo su "$(whoami)" -c "flatpak run org.flatpak.Builder \
-            --arch=${{ matrix.arch }} \
+            --arch=${MATRIX_ARCH} \
             --force-clean \
             --repo=repo \
             --sandbox \
             --stop-at=cuda build-sunshine ${APP_ID}.yml"
           cp -r .flatpak-builder copy-of-flatpak-builder
           sudo su "$(whoami)" -c "flatpak run org.flatpak.Builder \
-            --arch=${{ matrix.arch }} \
+            --arch=${MATRIX_ARCH} \
             --force-clean \
             --repo=repo \
             --sandbox \
             build-sunshine ${APP_ID}.yml"
           rm -rf .flatpak-builder
           mv copy-of-flatpak-builder .flatpak-builder
           sudo su "$(whoami)" -c "flatpak build-bundle \
-            --arch=${{ matrix.arch }} \
+            --arch=${MATRIX_ARCH} \
             ./repo \
-            ../artifacts/sunshine_${{ matrix.arch }}.flatpak ${APP_ID}"
+            ../artifacts/sunshine_${MATRIX_ARCH}.flatpak ${APP_ID}"
           sudo su "$(whoami)" -c "flatpak build-bundle \
             --runtime \
-            --arch=${{ matrix.arch }} \
+            --arch=${MATRIX_ARCH} \
             ./repo \
-            ../artifacts/sunshine_debug_${{ matrix.arch }}.flatpak ${APP_ID}.Debug"
+            ../artifacts/sunshine_debug_${MATRIX_ARCH}.flatpak ${APP_ID}.Debug"
           echo "::remove-matcher owner=gcc-strip3::"
 
       - name: Lint Flatpak
         working-directory: build
         run: |
-          exceptions_file="${{ github.workspace }}/packaging/linux/flatpak/exceptions.json"
+          exceptions_file="${GITHUB_WORKSPACE}/packaging/linux/flatpak/exceptions.json"
 
           echo "Linting flatpak manifest"
           flatpak run --command=flatpak-builder-lint org.flatpak.Builder \
@@ -211,7 +206,7 @@ jobs:
           tar -czf ./artifacts/flathub.tar.gz -C ./flathub .
 
       - name: Upload Artifacts
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@v5
         with:
           name: build-Linux-Flatpak-${{ matrix.arch }}
           path: artifacts/