fix(release): generate SBOM for QuerySpec.Analyzers package#249
Merged
AbongileBoja merged 1 commit intodevelopfrom Apr 29, 2026
Merged
fix(release): generate SBOM for QuerySpec.Analyzers package#249AbongileBoja merged 1 commit intodevelopfrom
AbongileBoja merged 1 commit intodevelopfrom
Conversation
Microsoft.Sbom.Targets 4.1.5 handles IncludeBuildOutput=false analyzer-shape packs correctly. The GenerateSBOM=false override from commit c9032a8 (PR #153) was set when Sbom.Targets 3.x could not emit the manifest into a no-build-output pack; that limitation no longer exists. Removing the override lets Directory.Build.props drive SBOM generation for all packable projects uniformly. Local verification: dotnet pack produces _manifest/spdx_2.2/manifest.spdx.json in the archive (31 423 bytes, 22 packages detected). Fixes #248
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes
<GenerateSBOM>false</GenerateSBOM>fromQuerySpec.Analyzers.csproj. This flag was introduced in commitc9032a8(PR #153) becauseMicrosoft.Sbom.Targets3.x could not generate an SBOM forIncludeBuildOutput=falseanalyzer-shape packs.Microsoft.Sbom.Targetswas bumped to 4.1.5 in PR #227; the limitation no longer exists. Removing the override restores the uniformDirectory.Build.props-driven SBOM generation for all packable projects.The v4.1.0 release gate correctly blocked publish because
QuerySpec.Analyzers.4.1.0.nupkgwas missing_manifest/spdx_2.2/manifest.spdx.json. This is the engineering fix; v4.1.1 will be the published release.Verification
Local pack with the fix applied:
Diff
One-line deletion from
src/QuerySpec.Analyzers/QuerySpec.Analyzers.csproj:- <GenerateSBOM>false</GenerateSBOM>Test plan
Verify SBOM in packagesstep passes for all 4 nupkgs includingQuerySpec.Analyzers