Update our fork to the latest upstream master #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some options have been renamed, most of them have been inverted to avoid double negation. If a deprecated option is used it will override the new one (with proper inversion) and a warning will be printed. Fixes: cucumber#213
…ns, but destructor is not virtual'
Fix cucumber#213: Inconsistent naming of CMake options
Fix cucumber#214: Better integration with CMake 3.13 (CMP0077)
This regression was introduced in commit a7ff906 (Regex: use iterators for match results).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which includes cucumber#221.
@mak-ableton, @nre-ableton, @toh-ableton: please review, thanks!