Introduce new class: Pipenv #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nre-ableton
force-pushed
the
nre/master/pipenv-multiple-python
branch
2 times, most recently
from
df8180d to
997ab7c
Compare
nre-ableton
force-pushed
the
nre/master/pipenv-multiple-python
branch
from
997ab7c to
8a25e65
Compare
|
re-ping @AbletonDevTools/gotham-city |
ala-ableton
reviewed
Oct 22, 2018
ala-ableton
reviewed
Oct 23, 2018
nre-ableton
force-pushed
the
nre/master/pipenv-multiple-python
branch
from
7521ff0 to
78cebe4
Compare
nre-ableton
force-pushed
the
nre/master/pipenv-multiple-python
branch
from
78cebe4 to
90770fe
Compare
|
Once there is a green PR on another repo that uses this class/singleton, LGTM 👍 |
|
@ala-ableton Thanks, but unfortunately because of pypa/pipenv#3079, that might be awhile. |
This class is designed to facilitate running a Pipenv command against multiple versions of Python, which is something that Pipenv cannot do by itself very gracefully. We do this by using the `--python` argument to Pipenv, which assumes that the `Pipfile` does not contain a `requirements` section which may cause Pipenv to throw an error.
nre-ableton
force-pushed
the
nre/master/pipenv-multiple-python
branch
from
90770fe to
3751f42
Compare
|
@ala-ableton Regarding the green PR on another repo: https://github.com/AbletonDevTools/ablbot/pull/186 I'm going to go ahead and merge this change, assuming there are no objections. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This class is designed to facilitate running a Pipenv command against
multiple versions of Python, which is something that Pipenv cannot do
by itself very gracefully. We do this by using the
--pythonargumentto Pipenv, which assumes that the
Pipfiledoes not contain arequirementssection which may cause Pipenv to throw an error.This is the first step in solving https://github.com/AbletonAppDev/devtools/issues/1340, ping @AbletonDevTools/gotham-city