-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
false childOrigin to skip origin check #74
Conversation
I added the same logic for originForReceiving. not sure it makes sense, but the tests pass |
Thanks for the contribution, @KutnerUri! I left a comment to consider on the issue you logged. I think I'd like to support a Nice job figuring out the codebase enough to make the changes you did, btw! |
thanks, waiting for a new version of penpal! 😃 I think we should document the |
Yeah, I agree. I'm cooking up those changes now. 🧑🍳 |
Thanks for your contribution, @KutnerUri! Released as 6.2.0. |
thanks! 🙏 |
Allow consumers to skip iframe origin url check in
connectToChild()
.This is useful when the iframe redirects, etc.
connectToChild()
already checks the message origin is the target iframe, so it should be ok.Closes #73