-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide single-threaded (no-locking) implementation of IMetadataEmit family of APIs. #52
Merged
jkoritzinsky
merged 52 commits into
AaronRobinsonMSFT:master
from
jkoritzinsky:imetadataemit
Jun 18, 2024
Merged
Provide single-threaded (no-locking) implementation of IMetadataEmit family of APIs. #52
jkoritzinsky
merged 52 commits into
AaronRobinsonMSFT:master
from
jkoritzinsky:imetadataemit
Jun 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blocked on AaronRobinsonMSFT/DNCP#13 |
…d start implementation.
…regular QI signature.
…IMetaDataAssemblyEmit
… remapping in the base implementation.
…instance for TranslateSigWithScope
…emaining member functions in terms of the helpers.
…m as the 0'th element of each heap)
…es not specify them (as DNMD doesn't zero-initialize columns)
…ength blobs and no-blob-heap images.
…list and fix some corner case bugs around it
…ix build failures
TestResults/70c686e7-6d42-450f-99ba-e8caa33c201a/jekoritz_JEKORITZ_2024-02-15.14_59_51.coverage
Outdated
Show resolved
Hide resolved
TestResults/70c686e7-6d42-450f-99ba-e8caa33c201a/jekoritz_JEKORITZ_2024-02-15.14_59_51.coverage
Outdated
Show resolved
Hide resolved
AaronRobinsonMSFT
approved these changes
Jun 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Merge when you're ready.
…en't accidentally committed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide implementations of
IMetaDataEmit
,IMetaDataEmit2
, andIMetaDataAssemblyEmit
.