Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide single-threaded (no-locking) implementation of IMetadataEmit family of APIs. #52

Merged
merged 52 commits into from
Jun 18, 2024
Merged

Provide single-threaded (no-locking) implementation of IMetadataEmit family of APIs. #52

merged 52 commits into from
Jun 18, 2024

Conversation

jkoritzinsky
Copy link
Collaborator

@jkoritzinsky jkoritzinsky commented Jan 16, 2024 •
edited
Loading

Provide implementations of IMetaDataEmit, IMetaDataEmit2, and IMetaDataAssemblyEmit.

@jkoritzinsky
Copy link
Collaborator Author

Blocked on AaronRobinsonMSFT/DNCP#13

@jkoritzinsky jkoritzinsky marked this pull request as ready for review January 19, 2024 02:06
@jkoritzinsky
Add C++ RAII helper for row adds. Add declaration of IMetaDataEmit an…
b04ad89 
…d start implementation.
@jkoritzinsky
Implement saving.
3e967bc
@jkoritzinsky
Implement more methods.
253b9f4
@jkoritzinsky
Change md_apply_delta to take a delta image handle instead of the raw…
cefd384 
… data.
@jkoritzinsky
Implement IMetadataEmit::ApplyEditAndContinue
9132aed
@jkoritzinsky
Implement most of DefineImportType
3d42493
@jkoritzinsky
Implement DefineMemberRef and fix QIs in DefineImportType to use the …
d978f36 
…regular QI signature.
@jkoritzinsky
Stub out EnC-related methods and implement a few more methods
4ed2f5f
@jkoritzinsky
Implement DefineField
c8821b8
@jkoritzinsky
Implement SetFieldProps
538d8bc
@jkoritzinsky
Implement most of the remaining APIs on IMetaDataEmit/IMetaDataEmit2/…
108317a 
…IMetaDataAssemblyEmit
@jkoritzinsky
Implement Param methods
6136ed5
@jkoritzinsky
Provide a no-op implementation of SetHandler as we don't do any token…
f5cff9d 
… remapping in the base implementation.
@jkoritzinsky
Fix errors and correctly handle names in SetParamProps
0b7966d
@jkoritzinsky
Remove TranslateSigWithScope helper and delegate back to the correct …
48f79b6 
…instance for TranslateSigWithScope
@jkoritzinsky
Merge metadataemithelpers and importhelpers
ac00eb1
@jkoritzinsky
Use helpers instead of re-implementing the algorithms and implement r…
84520b6 
…emaining member functions in terms of the helpers.
@jkoritzinsky
Don't use UINT32 type as it's not defined by dncp
0195a85
@jkoritzinsky
Update dncp
51c83ff
@jkoritzinsky
Fix Clang failures
3eceff0
@jkoritzinsky
Define IMetaDataAssemblyEmit IID
cdc4e8c
@jkoritzinsky
Add override specifier
69d4d30
@jkoritzinsky
Make DefineScope result editable
b14b2db
@jkoritzinsky
Correctly handle null heap entries as per the ECMA-335 spec (emit the…
34d3111 
…m as the 0'th element of each heap)
@jkoritzinsky
Zero-initialize each column in the ::DefineX methods when the user do…
2e24a1a 
…es not specify them (as DNMD doesn't zero-initialize columns)
@jkoritzinsky
Initialize currentImplementation
8820812
@jkoritzinsky
Fix incorrect dereference
d78baa3
@jkoritzinsky
Add CMake option to enable msvc profiling to enable code coverage in …
c83191e 
…VS tests.
@jkoritzinsky
Add tests for SetModuleProps
ef58687
@jkoritzinsky
Implement tests for defining typedefs and fix bugs found in the process.
df8f518
@jkoritzinsky
Add test for SetTypeDefProps
3c75715
@jkoritzinsky
Flip include order for non-Windows
061e4d5
@jkoritzinsky
Add basic "define MethodDef" test and fix bugs.
28229cf
@jkoritzinsky
Add more methoddef tests and standalonesig tests
9491f51
@jkoritzinsky
Add tests for MemberRef
027ece6
@jkoritzinsky
Add tests for TypeSpec
b611631
@jkoritzinsky
Add Assembly test and update DNMD APIs to behave better around zero-l…
374ebda 
…ength blobs and no-blob-heap images.
@jkoritzinsky
Add AssemblyRef test
858aac7
@jkoritzinsky
Add some parameter tests that also set constants
361b5e8
@jkoritzinsky
Add a test for out of order parameters at the start of the parameter …
dbc497d 
…list and fix some corner case bugs around it
@jkoritzinsky
Add tests for FieldMarshal and FieldRva table-related APIs and fix un…
ef6747d 
…ix build failures
@jkoritzinsky
Just avoid using max
1d4c98f
@jkoritzinsky
Include cstddef for size_t
bc23799
@jkoritzinsky
Fix incorrect wide-char spec
ce744d3
@jkoritzinsky
Add necessary const casts
4661260
AaronRobinsonMSFT
AaronRobinsonMSFT reviewed Jun 12, 2024
View reviewed changes
src/dnmd/editor.c Outdated Show resolved Hide resolved
src/dnmd/editor.c Outdated Show resolved Hide resolved
src/dnmd/editor.c Outdated Show resolved Hide resolved
src/dnmd/editor.c Outdated Show resolved Hide resolved
src/dnmd/streams.c Show resolved Hide resolved
src/interfaces/importhelpers.cpp Outdated Show resolved Hide resolved
src/mddump/main.cpp Outdated Show resolved Hide resolved
src/mdmerge/main.cpp Outdated Show resolved Hide resolved
src/interfaces/metadataemit.cpp Outdated Show resolved Hide resolved
src/interfaces/metadataemit.cpp Outdated Show resolved Hide resolved
AaronRobinsonMSFT
AaronRobinsonMSFT approved these changes Jun 15, 2024
View reviewed changes
Copy link
Owner

@AaronRobinsonMSFT AaronRobinsonMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Merge when you're ready.

@jkoritzinsky jkoritzinsky merged commit 7a3ace4 into AaronRobinsonMSFT:master Jun 18, 2024
12 checks passed
@jkoritzinsky jkoritzinsky deleted the imetadataemit branch June 18, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronRobinsonMSFT AaronRobinsonMSFT AaronRobinsonMSFT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkoritzinsky @AaronRobinsonMSFT