Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement signature importing #48

Merged
merged 23 commits into from
Jan 10, 2024

Conversation

jkoritzinsky
Copy link
Collaborator

Implement the logic for IMetaDataEmit::TranslateSigWithScope (and IMetaDataEmit::ImportTypeDef) in dnmd::interfaces.

As this logic is really complex, and is the only code that needs to do signature walking, I wanted to implement it in a separate PR from the IMetaDataEmit PR to help reduce the size and complexity of that one.

This PR still needs tests. I think I'll finally add a "make a new Metadata image" API to dnmd (in a separate PR) to enable us to add unit tests for bespoke scenarios (the majority of the code in this PR is bespoke scenarios that will be difficult to test by only using existing assemblies).

Copy link
Owner

@AaronRobinsonMSFT AaronRobinsonMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a lot going on in this PR. I need to do another pass.

src/inc/dnmd.hpp Outdated Show resolved Hide resolved
src/inc/dnmd.hpp Outdated Show resolved Hide resolved
src/inc/dnmd.hpp Outdated Show resolved Hide resolved
src/inc/internal/span.hpp Outdated Show resolved Hide resolved
src/inc/internal/span.hpp Outdated Show resolved Hide resolved
src/interfaces/importhelpers.hpp Outdated Show resolved Hide resolved
src/interfaces/pal.cpp Outdated Show resolved Hide resolved
src/interfaces/pal.cpp Outdated Show resolved Hide resolved
src/interfaces/pal.hpp Outdated Show resolved Hide resolved
src/interfaces/signatures.cpp Show resolved Hide resolved
src/inc/dnmd.hpp Outdated Show resolved Hide resolved
src/interfaces/signatures.cpp Outdated Show resolved Hide resolved
src/interfaces/signatures.cpp Outdated Show resolved Hide resolved
src/interfaces/signatures.hpp Outdated Show resolved Hide resolved
src/interfaces/signatures.cpp Show resolved Hide resolved
src/interfaces/importhelpers.cpp Outdated Show resolved Hide resolved
src/interfaces/importhelpers.cpp Outdated Show resolved Hide resolved
src/interfaces/importhelpers.cpp Outdated Show resolved Hide resolved
src/interfaces/importhelpers.cpp Outdated Show resolved Hide resolved
src/interfaces/importhelpers.cpp Outdated Show resolved Hide resolved
@jkoritzinsky jkoritzinsky merged commit e727af4 into AaronRobinsonMSFT:master Jan 10, 2024
12 checks passed
@jkoritzinsky jkoritzinsky deleted the import-sig branch January 10, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants