Implement signature importing #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…metadataemit branch and make it a free function that operates on DNMD handles.
Co-authored-by: Aaron Robinson <[email protected]>
…ssembly referenced by a nil ResolutionScope in the source module.
… assembly (as the CoreCLR does)
…me shape from CommonCrypto
AaronRobinsonMSFT
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the logic for
IMetaDataEmit::TranslateSigWithScope(andIMetaDataEmit::ImportTypeDef) indnmd::interfaces.As this logic is really complex, and is the only code that needs to do signature walking, I wanted to implement it in a separate PR from the
IMetaDataEmitPR to help reduce the size and complexity of that one.This PR still needs tests. I think I'll finally add a "make a new Metadata image" API to
dnmd(in a separate PR) to enable us to add unit tests for bespoke scenarios (the majority of the code in this PR is bespoke scenarios that will be difficult to test by only using existing assemblies).