Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Feature Request - Request count of List Items and last updated date #57

Closed
OttScott opened this issue Apr 2, 2022 · 7 comments
Closed
Labels
feature request new feature help wanted Extra attention is needed high priority

Comments

@OttScott
Copy link

OttScott commented Apr 2, 2022

Problem Statement:
If using multiple browsers on multiple machines, I'd like to know that all my Black\White lists contain the same items, or failing that, the same number of items. Additionally, as I make changes to my lists, it would be helpful to know the last import date (or update date) of a given list so that I know the lists are at least up to date with a certain source file date.

Requesting a Count of items contained within a Blac/White Keyword or URL list.
Also, requesting a last import/updated date of same lists.

Both features would allow user to determine if lists are properly imported or up to date with all browsers using this extension. Both date and count perhaps are overkill, but it would be helpful to know that I successfully imported my lists across all my browsers on all my machines.

Larger Feature of Cloud-Sync of lists would probably obviate this feature.

Your environment

  • 2.6.4
  • Edge\Chrome newest

Steps to reproduce

Open Extension Options page
Select Blacklist or Whitelist
Import a large (more items than fit in the window so scroll-bars appear) selection of URLs or keywords
Do the same on another browser and add more items
Compare the lists in both browsers. Are the lists the same?

@AXeL-dev
Copy link
Owner

AXeL-dev commented Apr 2, 2022

As you said, i think that the storage sync solution would be a better approach for that 🤔.

Still adding the list count isn't a bad idea, but for the export date i think that you can simply know that from the export file creation date (still this would not resolve the case/need of an import date, for sure).

@OttScott
Copy link
Author

OttScott commented Apr 6, 2022

Import Date isn't strictly a requirement, it just ties the data to a specific sync-state that could be tied to a given sync event. In the case of file-based sync, it's largely moot, but for Storage Sync you might be tracking the metadata anyway. I don't really think it's necessary to expose it to the user, but the current count of items in the list would be handy.

And please note, I do not consider this to be an important feature. If the UI of the Framework doesn't easily expose the list count or make it easy to display, I'd close as Won't-Fix. But Storage Sync... That'd be a useful thing... :D

@AXeL-dev
Copy link
Owner

AXeL-dev commented Apr 6, 2022

@OttScott both list count & import date are easy to implement, still the storage sync is something i never did before so it might require some time to be correctly implemented & tested.

I'll try to have a look on this feature request this weekend, but in the meanwhile, do you have any suggestion for where to put the import date on the UI? maybe below the lists?

@OttScott
Copy link
Author

OttScott commented May 5, 2022

@AXeL-dev Last Import Date might be replaced by Last Sync Date once implemented, but yeah, I think right below the lists is the best place. Maybe it should be Last Modified Date so any additions that were made would be known as well. Probably easier to implement anyway.

@AXeL-dev
Copy link
Owner

AXeL-dev commented May 8, 2022

@OttScott what do you think of this?

Peek 08-05-2022 14-47

@AXeL-dev AXeL-dev removed the todo Todo task label May 8, 2022
@OttScott
Copy link
Author

OttScott commented May 8, 2022

Amazing! Far better than I thought it'd be.
image

@AXeL-dev
Copy link
Owner

AXeL-dev commented May 8, 2022

Deployed in version 2.6.5, it may take some time until it becomes available on chrome & edge.

@AXeL-dev AXeL-dev closed this as completed May 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request new feature help wanted Extra attention is needed high priority
Projects
None yet
Development

No branches or pull requests

2 participants