Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Remove Password Requirement to Enable Blocking #50

Closed
OttScott opened this issue Feb 24, 2022 · 6 comments
Closed

Feature Request: Remove Password Requirement to Enable Blocking #50

OttScott opened this issue Feb 24, 2022 · 6 comments
Labels
enhancement New feature or request

Comments

@OttScott
Copy link

It makes little sense to require a password in order to enable the service. In current form, a user would have to type in his password, potentially having to find it, or retrieve it from a password vault, in order to turn on the blocker.
I could potentially see some edge case where the current implementation would prevent pranks when a browser is left logged in. That aside, however, I would consider the default use case as:

  1. User decides he/she needs to be uninterrupted
  2. Clicks Distract-Me-Not
  3. Clicks Enable

Attempting to Disable the blocker outside of schedule, or any configuration changes should continue to require a password.

@AXeL-dev
Copy link
Owner

AXeL-dev commented Feb 24, 2022

Hum, i'm not sure to get what you mean 🤔, since the password is mainly there to protect your settings from being changed/accessed by someone else.

Actually, we have those too options (see the screenshots below), that let you bypass the password in some cases:
Capture d'écran Deepin_zone de sélection _20220224090837
Capture d'écran Deepin_zone de sélection _20220224090853

Still from what i understood, you're asking for a way to disable the password requirement in some other cases? like being able to enable/disable the extension without entering the password (even when pass-protection is enabled).

Edit: My bad.. you're only asking for a way to enable the extension without entering the password, the disable part should still ask for the password, right?

@AXeL-dev AXeL-dev added the enhancement New feature or request label Feb 24, 2022
@AXeL-dev
Copy link
Owner

AXeL-dev commented Feb 24, 2022

Actually, after thinking a little more about this, i'm wondering why not to add a "timer" mode:

Capture d'écran Deepin_zone de sélection _20220224210523

Once you access the panel, you have a timer mode button, you click on it, you enter the amount of time for which you don't want to be disturbed, the timer starts counting & disallow you to disable the extension. Would that fit your needs?

Self-note: It would be interesting to add an option that displays a notification to the user once the timer ends.
Self-note 2: It would also be interesting to display a warning for the user, that the timer mode cannot be disabled until the session ends.
Self-note 3: Think to save the timer status somewhere in the local storage, to avoid bypassing it by restarting the browser (or would that be too much restricted? 🤔).

@OttScott
Copy link
Author

Not quite what I mean. Say I'm sitting down to work on a project and I realize I'm getting distracted. I have ADHD so I have a password which makes it harder to turn off DMN impulsively. I sit down to work on my project and click the dimmed (off) DMN icon and am prompted to enter my password.
image
Then I have to open my password manager and find my password.
image
Now that I can unlock DMN, I can finally get in and turn on the don't distract me I'm hoping for.
image

What I'm suggesting is that password would only be required if DMN is Active or to open Config. Perhaps as you've designed it, changing modes would prompt also. But if it is not in block mode, please allow me to easily switch it on so I don't get distracted until I switch it on. 🤣

I do think your timer idea is also a great feature. You could enable timer and see the countdown (without password) from clicking the icon, but can't disable it or change config until you supply the password. Kind of like an 'Are you sure?' button...

@AXeL-dev
Copy link
Owner

AXeL-dev commented Feb 25, 2022

How about this:

Capture d'écran Deepin_zone de sélection _20220225124150

Peek 25-02-2022 12-54

Edit: i made it optional for users that prefer to keep the previous behavior.

@OttScott
Copy link
Author

Perfect!

AXeL-dev added a commit that referenced this issue Feb 27, 2022
@AXeL-dev AXeL-dev mentioned this issue Feb 27, 2022
@AXeL-dev
Copy link
Owner

Deployed in version 2.6.2 (might need to wait for few days until it gets published).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants