Drop Illuminate/Support requirement

[JayBizzle]

Pretty sure you don't need to depend on illuminate/support as none of the code in the package uses it directly and the dependency is enforce by the parent lord/laroute package 👍

[forxer]

👍

[sergejostir]

Well, it is used now

laravel-laroute/src/Routes/Collection.php

Line 40 in 4feb9ab

return Arr::only($data, ['uri', 'name']);

so this should be reverted I guess.

[JayBizzle]

Yes, we should revert 3582aef

[sergejostir]

What? Then the new dependency would be laravel/helpers.

[forxer]

Pretty sure you don't need to depend on illuminate/support as none of the code in the package uses it directly and the dependency is enforce by the parent lord/laroute package 👍

This is fine, since lord/laroute require illuminate/support we don't need to require it in this package.

[JayBizzle]

Ha, totally forgot about that 😂👍

[sergejostir]

Pretty sure you don't need to depend on illuminate/support as none of the code in the package uses it directly and the dependency is enforce by the parent lord/laroute package 👍

This is fine, since lord/laroute require illuminate/support we don't need to require it in this package.

Well, that is kinda bad practice. The package should clearly state all its requirements. Hypotetically lord/laroute can drop illuminate/support as its requirement at any time and as a result also breaking your package.
Or let's say, someone creates a replacement package (using composer's "replace" functionality) to lord/laroute without using illuminate/support and again your package will then not work.

[forxer]

@sergiz I quite agree with you in theory but less in practice.

The idea behind this change was that you could continue to use this package transparently without our intervention when a new release of Laravel occurs and that the package we are extending (lord/laroute) controls dependencies.

But ok I will put back the prerequisites to make it "cleaner" and in this case we also have to add the laravel/routing dependency which is not the case from the beginning.

[sergejostir]

I understand. Well, if you do not care about something breaking it, an option is also to specify dependency as ">=5.4".

[forxer]

Ok we have decided to release a new 1.7.0 version with this compromise.

(Otherwise yes: we know that we are not following SEMVER; it will be for a future 2.0)

Thank you all