Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds tqdm handler to logging_config.py for progress bar integration #13996

Merged
merged 3 commits into from
Nov 19, 2023

Conversation

Luxter77
Copy link
Contributor

Description

  • Integrates tqdm handler into logging configuration for progress bar display during logging (previously, the logging messages would interfere with any running progress bar).
  • Adds a new TqdmLoggingHandler as an extra handler for the basicConfig.
  • This commit doesn't fix any specific issues but improves the user experience.

Screenshots/videos:

N/A

Checklist:

@Luxter77
Copy link
Contributor Author

Could someone help me understand why does this test fail complaining about tqdm not being installed?

I see it is not explicitly in any requirement file, but also see it being use all around the codebase..?

@Luxter77
Copy link
Contributor Author

ah, the launch script installs it, so it cannot be yet used.

@AUTOMATIC1111 AUTOMATIC1111 merged commit 3a13b0e into AUTOMATIC1111:dev Nov 19, 2023
3 checks passed
@w-e-w w-e-w mentioned this pull request Dec 4, 2023
@w-e-w w-e-w mentioned this pull request Dec 16, 2023
@akx
Copy link
Collaborator

akx commented Dec 25, 2023

This PR seems to have broken logging somehow for me.

Try env SD_WEBUI_LOG_LEVEL=debug ... – it doesn't output debug logs at all; if you get rid of handlers=loghandlers, they start appearing again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants