Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds 'Path' sorting for Extra network cards #13968

Merged

Conversation

kaalibro
Copy link
Contributor

Description

Sorry for re-creating the PR, but I messed up with commits in my fork and created a new one from scratch :)

Related commit: d9499f4

Sorting by "Name" does not take into account nested directories if loras are placed in them. When there are a lot of loras, the "Path" sorting makes it convenient to control their display order in the "all" subdir tab using directory naming.

For example, after the loras in the root directory, I need the "all" tab to display the loras from the "Tweaks" subdir first, then "Style", and finally "Character". I name these subdirs appropriately and get the result I want. Sorting by "Name" sends character loras to the top of the list for obvious reasons. Organizing directories loses its meaning.

Using subdir tabs is not always handy, because when you change tab, for example, from "Lora" to "Checkpoints" you have to click them every time to change the "Search" value. It is easier to organize the cards displaying order using directory names once, and use the subdir tabs as needed.

Also, sorting by "Path" now works correctly for "Textual Inversions" too. Before that, the "Default Sort" worked there in a similar way with "Name".

Screenshots/videos:

Files structure
Sort by Path
Sort by Name

Checklist:

@AUTOMATIC1111 AUTOMATIC1111 merged commit e4e875f into AUTOMATIC1111:dev Nov 19, 2023
3 checks passed
@kaalibro kaalibro deleted the extranetworks-path-sorting branch November 19, 2023 20:14
@w-e-w w-e-w mentioned this pull request Dec 4, 2023
@w-e-w w-e-w mentioned this pull request Dec 16, 2023
@alexbofa
Copy link

alexbofa commented Dec 28, 2023

Hello. Tell me, please, what kind of a nice design does LoRA have?

@kaalibro
Copy link
Contributor Author

Hello. Tell me, please, what kind of a nice design does LoRA have?

это я в фигме отрисовал) для красивого UI сейчас юзаю вот этот экстеншен

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants