Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

call state.jobnext() before postproces*() #13762

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

wkpark
Copy link
Contributor

@wkpark wkpark commented Oct 25, 2023

Description

  • call state.jobnext() before postprocess*() to support job_count, job_no controls in postprocessing easily.

with this small fix, state.job_count and state.job_no could be easily controlled without hacky ways.

  • without this fix, one can control job_count and job_no in postprocess*() by the following hacky way:
    • increase job_no in the postprocess*() - HACK
    • increase job_count in the postprocess* (slight jumping back progress bar)
    • decrease job_no before return. (possible live progress bar jumping back too much will occur) - HACK

Show case (with or without this fix. above hacky workaround applied)

  • webui + a face detailer extension with progress support (postprocess extension, use postprocess_image() internally)
jum.back3.mp4

Checklist:

@AUTOMATIC1111 AUTOMATIC1111 merged commit 21d5618 into AUTOMATIC1111:dev Nov 3, 2023
3 checks passed
@w-e-w w-e-w mentioned this pull request Dec 4, 2023
@w-e-w w-e-w mentioned this pull request Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants