Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing k-diffusion sigma params to infotext #12358

Merged
merged 4 commits into from
Aug 6, 2023

Conversation

catboxanon
Copy link
Collaborator

Description

Put these in the infotext now that they actually all work. :^)

Related:
#12354
#12356
#12357

Checklist:

@AUTOMATIC1111
Copy link
Owner

Accessing p.override_settings does not seem right. The values would be in shared.opts.

@catboxanon
Copy link
Collaborator Author

catboxanon commented Aug 6, 2023

See the related PRs and the comment in this commit for why I'm doing it like this. They're currently defined in StableDiffusionProcessing and they're initially read from opts there.

@AUTOMATIC1111
Copy link
Owner

what I mean is,

p.override_settings.get('s_churn', p.s_churn)

should be

getattr(opts, 's_churn', p.s_churn)

@catboxanon catboxanon marked this pull request as draft August 6, 2023 03:42
@catboxanon catboxanon marked this pull request as ready for review August 6, 2023 03:51
@catboxanon
Copy link
Collaborator Author

Fixed now. Linter is complaining about d86d12e, not actually anything from this PR

@AUTOMATIC1111 AUTOMATIC1111 merged commit 06da34d into AUTOMATIC1111:dev Aug 6, 2023
2 of 3 checks passed
@w-e-w w-e-w mentioned this pull request Aug 24, 2023
@catboxanon catboxanon deleted the sigma-infotext branch March 4, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants