Skip to content

feat(component-news): added hideTags prop that defaults to true #1584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 7, 2025
Merged

feat(component-news): added hideTags prop that defaults to true #1584

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
15af534
feat(component-news): added hideTags prop that defaults to true
davidornelas11 Sep 24, 2025
cb5bc78
Update packages/component-news/src/components/CardGridNews/index.jsx
mlsamuelson Oct 27, 2025
329a1dc
chore(component-news): Add proptypes validation for grid news
davidornelas11 Oct 27, 2025
f895f95
Merge pull request #1597 from ASU/uds-2056-add-proptypes
davidornelas11 Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/component-news/src/components/CardCarouselNews/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ const CarouselTemplate = ({ cardButton }) => {
const cardItems = feeds?.map((feed, index) =>
cardRow(feed, index, cardButton)
);

return (
<NewsWrapper>
<CardCarousel
Expand Down
12 changes: 7 additions & 5 deletions packages/component-news/src/components/CardGridNews/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import { NewsWrapper } from "./index.styles";
* @param {Object} feed
* @param {import("../../core/types/news-types").CardButton} cardButton
*/
const gridRow = (feed, cardButton) => (
const gridRow = (feed, cardButton, hideTags) => (
<div
className="col col-12 col-md-6 col-lg-4 cards-items-container"
key={feed.id}
Expand All @@ -38,7 +38,7 @@ const gridRow = (feed, cardButton) => (
href: feed.buttonLink,
},
]}
tags={parseInterests(feed?.interests)}
tags={hideTags ? [] : parseInterests(feed?.interests)}
/>
</div>
);
Expand All @@ -47,13 +47,14 @@ const gridRow = (feed, cardButton) => (
* @param {import("../../core/types/news-types").TemplateProps} props
*/

const GridTemplate = ({ cardButton }) => {
const GridTemplate = ({ cardButton, hideTags }) => {
const { feeds } = useContext(FeedContext); // Reading the "feeds" object from the context
const shouldHideTags = hideTags === true || hideTags === "true";

return (
<NewsWrapper className="row row-spaced" data-testid="grid-view-container">
{feeds?.map((feed, index) => (
<React.Fragment key={index}>{gridRow(feed, cardButton)}</React.Fragment>
<React.Fragment key={index}>{gridRow(feed, cardButton, shouldHideTags)}</React.Fragment>
))}
</NewsWrapper>
);
Expand All @@ -67,7 +68,7 @@ const GridTemplate = ({ cardButton }) => {
/**
* @param {FeedType} props
*/
const CardGridNews = ({ cardButton, ...props }) => {
const CardGridNews = ({ cardButton, hideTags = true, ...props }) => {
useEffect(() => {
if (typeof window !== "undefined") {
trackReactComponent({
Expand All @@ -87,6 +88,7 @@ const CardGridNews = ({ cardButton, ...props }) => {
<BaseFeed {...props}>
<GridTemplate
cardButton={{ ...defaultProps.cardButton, ...cardButton }}
hideTags={hideTags}
/>
</BaseFeed>
);
Expand Down
16 changes: 10 additions & 6 deletions packages/component-news/src/components/CardListlNews/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,14 @@ import { BaseFeed } from "../../core/components/BaseFeed";
import { defaultProps } from "../../core/constants/default-props";
import { parseInterests } from "../../core/utils";
import { NewsWrapper } from "./index.styles";
import PropTypes from "prop-types";

/**
* @param {object} feed
* @param {import("../../core/types/news-types").CardButton} cardButton
* @param {boolean} hideTags
*/
const listRow = (feed, cardButton) => (
const listRow = (feed, cardButton, hideTags) => (
<div className="card card-hover cards-items-container" key={feed.id}>
<Card
type="story"
Expand All @@ -35,7 +37,7 @@ const listRow = (feed, cardButton) => (
href: feed.buttonLink,
},
]}
tags={parseInterests(feed?.interests)}
tags={hideTags ? [] : parseInterests(feed?.interests)}
/>
</div>
);
Expand All @@ -44,13 +46,14 @@ const listRow = (feed, cardButton) => (
* @param {import("../../core/types/news-types").TemplateProps} props
*/

const ListTemplate = ({ cardButton }) => {
const ListTemplate = ({ cardButton, hideTags }) => {
const { feeds } = useContext(FeedContext); // Reading the "feeds" object from the context
const shouldHideTags = hideTags === true || hideTags === "true";

return (
<NewsWrapper className="row-spaced" data-testid="list-view-container">
{feeds?.map((feed, index) => (
<React.Fragment key={index}>{listRow(feed, cardButton)}</React.Fragment>
<React.Fragment key={index}>{listRow(feed, cardButton, shouldHideTags)}</React.Fragment>
))}
</NewsWrapper>
);
Expand All @@ -64,7 +67,7 @@ const ListTemplate = ({ cardButton }) => {
/**
* @param {FeedType} props
*/
const CardListlNews = ({ cardButton, ...props }) => {
const CardListlNews = ({ cardButton, hideTags = true, ...props }) => {
useEffect(() => {
if (typeof window !== "undefined") {
trackReactComponent({
Expand All @@ -84,11 +87,12 @@ const CardListlNews = ({ cardButton, ...props }) => {
<BaseFeed {...props}>
<ListTemplate
cardButton={{ ...defaultProps.cardButton, ...cardButton }}
hideTags={hideTags}
/>
</BaseFeed>
);
};

CardListlNews.propTypes = { ...BaseFeed.propTypes, feedCardButtonShape };
CardListlNews.propTypes = { ...BaseFeed.propTypes, feedCardButtonShape, hideTags: PropTypes.oneOf(["true", "false", true, false]) };

export { CardListlNews };
1 change: 1 addition & 0 deletions packages/component-news/src/core/types/news-types.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
* @ignore
* @typedef {Object} TemplateProps
* @property {CardButton} cardButton
* @property {"true" | "false" | boolean} [hideTags]
*/

/**
Expand Down