Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for projects with named modules #356

Merged

Conversation

slarse
Copy link
Collaborator

@slarse slarse commented Feb 2, 2021

Fix #339

I labeled this as a feature, as previously we really did only support Java 8 and below. Now we have support for Java 9+, with modules. I've set the default compliance level to Java 11, as that's what we decided upon for the current paper.

Note that this also sets the Spoon version to the snapshot, as we need that for the module bugfix that went in today (see INRIA/spoon#3771).

@slarse slarse added the WiP label Feb 2, 2021
Same factory for all modules anyway
@slarse slarse changed the title feat: Set default compliance level to Java 11 (and thereby support modules) feat: Add support for projects with named modules Feb 2, 2021
@codecov
Copy link

codecov bot commented Feb 2, 2021

Codecov Report

Merging #356 (1ae74ba) into master (290bdc0) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #356      +/-   ##
============================================
+ Coverage     89.06%   89.08%   +0.02%     
- Complexity      620      623       +3     
============================================
  Files            66       66              
  Lines          2002     2007       +5     
  Branches        234      234              
============================================
+ Hits           1783     1788       +5     
  Misses          134      134              
  Partials         85       85              
Impacted Files Coverage Δ Complexity Δ
src/main/java/sorald/Constants.java 83.33% <100.00%> (+3.33%) 1.00 <0.00> (ø)
src/main/java/sorald/Repair.java 92.62% <100.00%> (+0.13%) 64.00 <4.00> (+3.00)
src/main/java/sorald/sonar/RuleVerifier.java 91.35% <100.00%> (ø) 12.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 290bdc0...1ae74ba. Read the comment docs.

@slarse slarse requested a review from khesoem February 2, 2021 15:28
@khesoem khesoem merged commit 446dc55 into ASSERT-KTH:master Feb 3, 2021
@khesoem
Copy link
Collaborator

khesoem commented Feb 3, 2021

Thanks @slarse

@slarse slarse deleted the issue/339-increase-default-complince-level branch April 19, 2021 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Spoon Java compliance level set too low, causes crash on encountering module-info.java
2 participants