-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for projects with named modules #356
Merged
khesoem
merged 10 commits into
ASSERT-KTH:master
from
slarse:issue/339-increase-default-complince-level
Feb 3, 2021
Merged
feat: Add support for projects with named modules #356
khesoem
merged 10 commits into
ASSERT-KTH:master
from
slarse:issue/339-increase-default-complince-level
Feb 3, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same factory for all modules anyway
slarse
changed the title
feat: Set default compliance level to Java 11 (and thereby support modules)
feat: Add support for projects with named modules
Feb 2, 2021
Codecov Report
@@ Coverage Diff @@
## master #356 +/- ##
============================================
+ Coverage 89.06% 89.08% +0.02%
- Complexity 620 623 +3
============================================
Files 66 66
Lines 2002 2007 +5
Branches 234 234
============================================
+ Hits 1783 1788 +5
Misses 134 134
Partials 85 85
Continue to review full report at Codecov.
|
Thanks @slarse |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #339
I labeled this as a feature, as previously we really did only support Java 8 and below. Now we have support for Java 9+, with modules. I've set the default compliance level to Java 11, as that's what we decided upon for the current paper.
Note that this also sets the Spoon version to the snapshot, as we need that for the module bugfix that went in today (see INRIA/spoon#3771).