Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use Spoon snapshot to fix incorrect indentation style #272

Merged

Conversation

slarse
Copy link
Collaborator

@slarse slarse commented Dec 7, 2020

Fix #256

The latest snapshot build of Spoon works for resolving the problem with incorrect indentation. I suggest we simply use the snapshot build of Spoon (except for when we make a release), as I'm fairly often contributing to Spoon to fix issues in Sorald.

@slarse slarse added the WiP label Dec 7, 2020
@codecov
Copy link

codecov bot commented Dec 9, 2020

Codecov Report

Merging #272 (97da0a1) into master (37cecc0) will increase coverage by 0.44%.
The diff coverage is 95.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #272      +/-   ##
============================================
+ Coverage     87.57%   88.01%   +0.44%     
- Complexity      447      485      +38     
============================================
  Files            47       52       +5     
  Lines          1521     1611      +90     
  Branches        208      213       +5     
============================================
+ Hits           1332     1418      +86     
- Misses          119      120       +1     
- Partials         70       73       +3     
Impacted Files Coverage Δ Complexity Δ
src/main/java/sorald/Constants.java 75.00% <ø> (ø) 1.00 <0.00> (ø)
src/main/java/sorald/Main.java 60.00% <0.00%> (-20.00%) 2.00 <0.00> (ø)
src/main/java/sorald/event/StatsMetadataKeys.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
src/main/java/sorald/FileUtils.java 90.32% <66.66%> (-5.84%) 17.00 <3.00> (+3.00) ⬇️
src/main/java/sorald/cli/Cli.java 93.75% <92.30%> (-0.54%) 2.00 <1.00> (+1.00) ⬇️
...ald/event/collectors/MinerStatisticsCollector.java 96.00% <96.00%> (ø) 11.00 <11.00> (?)
src/main/java/sorald/event/EventType.java 100.00% <100.00%> (ø) 1.00 <0.00> (ø)
...c/main/java/sorald/event/models/ExecutionInfo.java 100.00% <100.00%> (ø) 5.00 <5.00> (?)
...main/java/sorald/event/models/WarningLocation.java 100.00% <100.00%> (ø) 7.00 <7.00> (?)
...main/java/sorald/event/models/miner/MinedRule.java 100.00% <100.00%> (ø) 4.00 <4.00> (?)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37cecc0...f4bafe6. Read the comment docs.

@slarse slarse changed the title wip: fix: Fix incorrect indentation style on added elements fix: Fix incorrect indentation style on added elements Dec 9, 2020
@slarse slarse changed the title fix: Fix incorrect indentation style on added elements fix: Use Spoon snapshot to fix incorrect indentation style on added elements Dec 9, 2020
@slarse slarse changed the title fix: Use Spoon snapshot to fix incorrect indentation style on added elements fix: Use Spoon snapshot to fix incorrect indentation style Dec 9, 2020
@monperrus monperrus merged commit 4c05ee8 into ASSERT-KTH:master Dec 9, 2020
@slarse slarse deleted the issue/256-fix-incorrect-indentation branch December 15, 2020 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Sorald always indents added elements with tabs
2 participants