Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality for inserting case #83

Merged
merged 9 commits into from
Jul 5, 2021
Merged

Add functionality for inserting case #83

merged 9 commits into from
Jul 5, 2021

Conversation

algomaster99
Copy link
Member

@algomaster99 algomaster99 commented Jun 27, 2021

Changes add functionality to insert a case in CtAbstractSwitch which includes CtSwitch and CtSwitchExpression. However, the latter has not been tested because this language feature came about in Java 12 (standardised in v14) and we currently compile to Java SE 11.

To be merged after:

@algomaster99 algomaster99 marked this pull request as ready for review June 30, 2021 12:37
@algomaster99
Copy link
Member Author

@slarse Marked it ready for review as the feature is working. I shall remove the workaround once INRIA/spoon#4015 is merged.

@algomaster99 algomaster99 requested a review from slarse June 30, 2021 12:38
Copy link
Collaborator

@slarse slarse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But I suggest we wait with merging this Monday so we can use the new version of Spoon with the new method.

@slarse
Copy link
Collaborator

slarse commented Jul 5, 2021

@algomaster99 is this done?

@algomaster99
Copy link
Member Author

@slarse yes, we can merge this.

@slarse slarse merged commit 71edf13 into main Jul 5, 2021
@slarse slarse deleted the insert-case branch July 5, 2021 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants