Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json input format not listed in dbamsg help #202

Closed
dcesari opened this issue Dec 11, 2019 · 2 comments
Closed

json input format not listed in dbamsg help #202

dcesari opened this issue Dec 11, 2019 · 2 comments
Assignees

Comments

@dcesari
Copy link
Member

dcesari commented Dec 11, 2019

dbamsg help convert
Usage: dbamsg convert [options] [filter] filename [filename [...]]
...
  -t, --type=type                  format of the input data ('bufr', 'crex',
                                   'csv')

But dbamsg -t json -d bufr works. Are there any other valid input formats not listed in the doc? Of course the same holds for other dbamsg subcommands.

@spanezz
Copy link
Contributor

spanezz commented Dec 12, 2019

I checked in the code, and it's csv, json, bufr, crex, and auto. auto looks inside the input file to determine if it's BUFR or CREX, but can't autodetect CSV or JSON, and I'm king of tempted of not documenting it, and say that if one specifies --type, one has a type to specify.

I've fixed the documentation about input types. Output types like --dest are still mostly only bufr and crex, although looking at the code it's high time it's refactored to promote at least JSON to a first-class citizen.

@spanezz
Copy link
Contributor

spanezz commented Jan 10, 2020

JSON is now available like BUFR and CREX everywhere an encoding may be specified, be it in command line tools and in the APIs.

I have not done the same for CSV, because we currently have 2 or 3 different CSV layouts. If we want to standardize on one (like the output of dbamsg dump --csv --interpreted), I can do the same with CSV

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants