Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

connectivity tests: Early test skip #14771

Merged
merged 1 commit into from
Jun 15, 2021
Merged

connectivity tests: Early test skip #14771

merged 1 commit into from
Jun 15, 2021

Conversation

ghseb
Copy link

@ghseb ghseb commented Jun 14, 2021

Summary of changes

Adding mbed-os subdirectories that are not required for a specific project to .mbedignore is a good way to reduce compilation time. Sometimes it happens that tests depend on ignored files, which causes the test-build to fail even though the corresponding feature/component is not configured. The reason is that the conditional that skips the test is placed after the includes.

PR for master already merged: #14767

Impact of changes

None

Migration actions required

None

Documentation

Not required, I guess.

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

Early test skip
b2e4fb0 
Adding mbed-os subdirectories that are not required for a specific project to .mbedignore is a good way to reduce compilation time. Sometimes it happens that tests depend on ignored files, which causes the test-build to fail even though the corresponding feature/component
is not configured. The reason is that the conditional that skips the test is placed after the includes.
@ghseb ghseb changed the title Early test skip connectivity tests: Early test skip Jun 14, 2021
@ciarmcom
Copy link
Member

@ghseb, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team June 14, 2021 10:30
@mergify mergify bot added needs: CI and removed needs: review labels Jun 14, 2021
@0xc0170 0xc0170 requested a review from andypowers June 14, 2021 11:30
andypowers
andypowers approved these changes Jun 14, 2021
View reviewed changes
Copy link
Collaborator

@andypowers andypowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 14, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Jun 14, 2021

Test run: SUCCESS

Summary: 5 of 5 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 972c8fd into ARMmbed:mbed-os-5.15 Jun 15, 2021
@mergify mergify bot removed the ready for merge label Jun 15, 2021
@ghseb ghseb deleted the early-test-skip-5.15 branch June 15, 2021 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andypowers andypowers andypowers approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.15.8
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ghseb @ciarmcom @0xc0170 @mbed-ci @andypowers