Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LWIP Broadcast socket option added #14752

Merged
merged 1 commit into from
Jun 15, 2021

Conversation

tymoteuszblochmobica
Copy link
Contributor

Summary of changes

This PR adds Broadcast socket option

Impact of changes

No impact

Migration actions required

Not needed

Documentation

None


Pull request type

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[x] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@pan-
@ATmobica

@mergify mergify bot added the needs: work label Jun 8, 2021
@ciarmcom ciarmcom requested review from pan- and a team June 8, 2021 23:30
@ciarmcom
Copy link
Member

ciarmcom commented Jun 8, 2021

@tymoteuszblochmobica, thank you for your changes.
@pan- @ARMmbed/mbed-os-connectivity @ARMmbed/mbed-os-maintainers please review.

@ciarmcom
Copy link
Member

ciarmcom commented Jun 9, 2021

@tymoteuszblochmobica, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot added needs: CI and removed needs: review labels Jun 9, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 9, 2021

@tymoteuszblochmobica can this be tested , should a test case be added to our tests?

@ciarmcom
Copy link
Member

This pull request has automatically been marked as stale because it has had no recent activity. @ARMmbed/mbed-os-maintainers, please start CI to get the PR merged.

@ciarmcom ciarmcom added the stale Stale Pull Request label Jun 10, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 11, 2021

CI started

@0xc0170 0xc0170 removed the stale Stale Pull Request label Jun 11, 2021
@mbed-ci
Copy link

mbed-ci commented Jun 11, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 11, 2021

@tymoteuszblochmobica can this be tested , should a test case be added to our tests?

Still waiting if there is a test case for this or should be added.

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 15, 2021

The integration test is tracked separately. this has been tested in another project. As it's simple addition, @ARMmbed/mbed-os-connectivity agreed to proceed.

@0xc0170 0xc0170 merged commit 3cf5f8e into ARMmbed:master Jun 15, 2021
@mergify mergify bot removed the ready for merge label Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants