Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CANMessage deep comparison operators #14662

Merged
merged 1 commit into from
May 25, 2021
Merged

Add CANMessage deep comparison operators #14662

merged 1 commit into from
May 25, 2021

Conversation

AGlass0fMilk
Copy link
Member

Summary of changes

Adds comparison operators (== and !=) for mbed::CANMessage. They are implemented as deep comparison operators, ie: they compare the actual values of each data member rather than a pointer comparison.

Impact of changes

Migration actions required

Documentation

None, operators are documented with doc comments.

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@pan- @0xc0170 @kjbracey-arm

@mergify mergify bot added the needs: work label May 16, 2021
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label May 16, 2021
@ciarmcom ciarmcom requested review from 0xc0170, pan- and a team May 16, 2021 19:00
@ciarmcom
Copy link
Member

@AGlass0fMilk, thank you for your changes.
@0xc0170 @pan- @ARMmbed/mbed-os-maintainers please review.

@ciarmcom
Copy link
Member

@AGlass0fMilk, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@AGlass0fMilk AGlass0fMilk force-pushed the can-message-comparison-operators branch from dfc1d3c to d16df8c Compare May 16, 2021 23:30
@AGlass0fMilk AGlass0fMilk force-pushed the can-message-comparison-operators branch from d16df8c to 6765988 Compare May 17, 2021 12:07
@AGlass0fMilk AGlass0fMilk force-pushed the can-message-comparison-operators branch from 6765988 to b9f2367 Compare May 18, 2021 12:33
@mergify mergify bot added needs: CI and removed needs: work labels May 18, 2021
@ciarmcom ciarmcom added the stale Stale Pull Request label May 19, 2021
@ciarmcom
Copy link
Member

This pull request has automatically been marked as stale because it has had no recent activity. @ARMmbed/mbed-os-maintainers, please start CI to get the PR merged.

@0xc0170 0xc0170 removed the stale Stale Pull Request label May 20, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented May 20, 2021

CI started

@ciarmcom ciarmcom added the stale Stale Pull Request label May 20, 2021
@mbed-ci
Copy link

mbed-ci commented May 20, 2021

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ❌

@mergify mergify bot added needs: work and removed needs: CI labels May 20, 2021
@ciarmcom ciarmcom removed the stale Stale Pull Request label May 20, 2021
@LDong-Arm
Copy link
Contributor

It's a connection issue with boards in CI: #14652 (comment)
Waiting for a fix from the test team first.

@ciarmcom ciarmcom added the stale Stale Pull Request label May 24, 2021
@adbridge
Copy link
Contributor

CI restarted

@mbed-ci
Copy link

mbed-ci commented May 25, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@adbridge adbridge merged commit 891805b into ARMmbed:master May 25, 2021
@adbridge adbridge removed ready for merge stale Stale Pull Request labels May 25, 2021
@mbedmain mbedmain added release-version: 6.12.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@pan- pan- Awaiting requested review from pan-

Assignees
No one assigned
Labels
component: core component: hal release-version: 6.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@AGlass0fMilk @ciarmcom @0xc0170 @mbed-ci @LDong-Arm @adbridge @mbedmain