Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake - Configure memory map per target to allow multiple add_executable #14355

Merged
merged 1 commit into from
Mar 1, 2021
Merged

CMake - Configure memory map per target to allow multiple add_executable #14355

merged 1 commit into from
Mar 1, 2021

Conversation

ladislas
Copy link
Contributor

Summary of changes

This PR fixes the issue when building multiple targets with add_executable by configuring the memory map link options to the target and not to mbed-core.

Impact of changes

None for existing code, allows for multiple targets per project.

Migration actions required

None

Documentation

None

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@0xc0170 @hugueskamba @rajkan01 @rwalton-arm

@ladislas ladislas mentioned this pull request Feb 26, 2021
Closed
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Feb 26, 2021
@ciarmcom
Copy link
Member

@ladislas, thank you for your changes.
@rajkan01 @hugueskamba @rwalton-arm @0xc0170 @ARMmbed/mbed-os-maintainers please review.

@ladislas ladislas force-pushed the feature/ladislas/cmake-map-per-target branch from 846561c to fd7ea73 Compare February 27, 2021 12:16
@mergify mergify bot added needs: CI and removed needs: review labels Mar 1, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 1, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Mar 1, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

rajkan01
rajkan01 approved these changes Mar 1, 2021
View reviewed changes
Copy link
Contributor

@rajkan01 rajkan01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xc0170 0xc0170 merged commit fbafcf2 into ARMmbed:master Mar 1, 2021
@mergify mergify bot removed the ready for merge label Mar 1, 2021
@ladislas ladislas deleted the feature/ladislas/cmake-map-per-target branch March 1, 2021 12:58
@mbedmain mbedmain added release-version: 6.9.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugueskamba hugueskamba hugueskamba approved these changes

@rajkan01 rajkan01 rajkan01 approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@rwalton-arm rwalton-arm Awaiting requested review from rwalton-arm

Assignees
No one assigned
Labels
component: tools release-version: 6.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ladislas @ciarmcom @0xc0170 @mbed-ci @hugueskamba @rajkan01 @mbedmain