Ancestor check #41
Closed
Ancestor check #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # lib/KeyboardAwareMixin.js
- Change method name "viewIsAncestorOf" as "viewIsDescendantOf" according to PR facebook/react-native#7876
|
Folks, I'm currently on family vacation, I won't be able to attend this till 14th. @JosephDev is right, you should change a little bit this branch |
|
any update on this PR? |
|
Can't merge this PR without rebasing against master @JosephDev. Will try to update mine later today if I find some time. |
|
@alvaromb okay. I'd like to latest version of this package with subpages :) thank you for your work in advance 👍 |
|
Please use the I've just updated it agains |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now work with sub pages....