Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to rotate generated Zernike modes #90

Merged
merged 2 commits into from
Jan 27, 2023

Conversation

spangly
Copy link
Contributor

@spangly spangly commented Jan 27, 2023

Added the ability to generate rotated Zernike modes with a new keyword (default to 0) in most functions in zernike.py

Also looks like I changed some of the default "range" to "xrange" in line with the python 2 to 3 optimisation in lines 4-11. Can't remember doing this however...so not sure when/where this came in...

@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

Base: 92.08% // Head: 92.10% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (2ea0a3c) compared to base (8d11f44).
Patch coverage: 90.00% of modified lines in pull request are covered.

❗ Current head 2ea0a3c differs from pull request most recent head b867abe. Consider uploading reports for the commit b867abe to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
+ Coverage   92.08%   92.10%   +0.01%     
==========================================
  Files          42       42              
  Lines        1997     2001       +4     
==========================================
+ Hits         1839     1843       +4     
  Misses        158      158              
Impacted Files Coverage Δ
aotools/functions/zernike.py 96.89% <90.00%> (+0.09%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@matthewtownson matthewtownson merged commit 8669dec into AOtools:main Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants