Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atmospheric params changes #83

Merged
merged 5 commits into from
Jul 21, 2022
Merged

Conversation

ojdf
Copy link
Contributor

@ojdf ojdf commented Mar 28, 2022

Added an axis parameter to isoplanaticAngle and coherenceTime, making these funcions compatible with multi-dimensional arrays, with the integration performed over this axis.

Also added a rytov_variance function because it might be useful.

Had to fix some tests for atmos_conversions as well.

@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #83 (34d51b0) into main (76dd3dc) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
- Coverage   92.10%   92.08%   -0.02%     
==========================================
  Files          42       42              
  Lines        1988     1997       +9     
==========================================
+ Hits         1831     1839       +8     
- Misses        157      158       +1     
Impacted Files Coverage Δ
aotools/turbulence/atmos_conversions.py 100.00% <100.00%> (ø)
test/test_atmos_conversions.py 100.00% <100.00%> (ø)
aotools/functions/karhunenLoeve.py 92.13% <0.00%> (-0.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76dd3dc...34d51b0. Read the comment docs.

@matthewtownson matthewtownson merged commit b3f8bfb into AOtools:main Jul 21, 2022
@ojdf ojdf deleted the params_changes branch July 26, 2022 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants