Fix bug, where seed in infinite screen had no effect #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because ft_phase_screen will use a system random number generator when seed is `None`, some seed must be given to make it repeatable.
Codecov Report
@@ Coverage Diff @@
## master #64 +/- ##
==========================================
- Coverage 92.61% 92.57% -0.05%
==========================================
Files 25 25
Lines 1314 1319 +5
==========================================
+ Hits 1217 1221 +4
- Misses 97 98 +1
Continue to review full report at Codecov.
|
|
Sorry I forgot about this, thanks for fixing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because ft_phase_screen will use a system random number generator when
seed is
None, some seed must be given to make it repeatable.