[WIP] Refactor to support dynamic sections #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor the `src/components/Radar/*` components and the `scripts/buildData.ts` together with `scripts/positioner.ts` to support more than 4 quadrants, now renamed to sections, and dynamically support 1 to 6 sections. * **Configuration Changes** - Rename "quadrants" to "sections" in `data/config.default.json`. - Update the "sections" array to support 1 to 6 sections. * **Script Changes** - Update `scripts/buildData.ts` to dynamically handle sections based on the configuration. - Update `scripts/positioner.ts` to dynamically calculate start angles for up to 6 sections. * **Component Changes** - Update `src/components/Radar/Chart.tsx` to dynamically calculate start angles for up to 6 sections. - Update `src/components/Radar/Label.tsx` and `src/components/Radar/Legend.tsx` to dynamically handle up to 6 sections. * **Library Changes** - Update `src/lib/data.ts` to return sections instead of quadrants. * **Documentation Changes** - Add a migration section in `README.md` and mention the new dynamic sections. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/AOEpeople/aoe_technology_radar?shareId=XXXX-XXXX-XXXX-XXXX).
|
@mathiasschopmans I see the build is failing due some renaming not fully refactored down the lane. Was this paused because of some complexities hidden in the other components? If not I can continue the renaming and try to have all checks for this PR turn green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the
src/components/Radar/*components and thescripts/buildData.tstogether withscripts/positioner.tsto support more than 4 quadrants, now renamed to sections, and dynamically support 1 to 6 sections.Configuration Changes
data/config.default.json.Script Changes
scripts/buildData.tsto dynamically handle sections based on the configuration.scripts/positioner.tsto dynamically calculate start angles for up to 6 sections.Component Changes
src/components/Radar/Chart.tsxto dynamically calculate start angles for up to 6 sections.src/components/Radar/Label.tsxandsrc/components/Radar/Legend.tsxto dynamically handle up to 6 sections.Library Changes
src/lib/data.tsto return sections instead of quadrants.Documentation Changes
README.mdand mention the new dynamic sections.For more details, open the Copilot Workspace session.