chore(deps): decline OpenApi v3 + js-yaml v5 majors; encode the rationale in renovate config - #479
Conversation
…onfig Both majors were evaluated and declined on evidence: - Microsoft.OpenApi 3.x: CS0200 in Microsoft.AspNetCore.OpenApi's generated XML-comment support (Example is read-only in v3) — reproduced today on latest 10.0.9; the pin in Directory.Packages.props stands (#462, #465). - js-yaml 5.x: the dep exists only as an overrides security floor; all consumers declare ^4.x and npm audit is clean — a forced major buys nothing and risks the generate:ts/shadcn toolchain (#425). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
There was a problem hiding this comment.
Pull request overview
Makes the decision to decline two Renovate major updates durable and self-documenting by encoding the rationale directly in Renovate config, so future Renovate runs won’t reopen the same majors without an intentional config change.
Changes:
- Adds a Renovate
packageRulesentry to disable major updates forMicrosoft.OpenApi(documenting the generated-code break caused by OpenAPI.NET v3). - Adds a Renovate
packageRulesentry to disable major updates forjs-yaml(documenting that it’s only anoverridessecurity floor and v5 would be out-of-range for current consumers).
Complete-and-verified
Resolution for the two open renovate majors (#465, #425): both decline on evidence, and this PR makes the decision durable + self-documenting via
packageRules(local rules merge on top of the fleet preset).Microsoft.OpenApi 2.9.0 → 3.7.0 (#465) — declined
IOpenApiMediaType.Exampleread-only. The Microsoft.AspNetCore.OpenApi XML-comment source generator still assigns it, producingCS0200in generated code (OpenApiXmlCommentSupport.generated.cs), which this repo's hard rules forbid hand-editing.Microsoft.AspNetCore.OpenApi(10.0.9 — no newer exists on NuGet): same two CS0200 errors as the PR's CI. Reverted, build back to 0 errors.Directory.Packages.propsdocuments the 2.9.0 pin (which also clears GHSA-v5pm-xwqc-g5wc). Blocked upstream until ASP.NET's generator supports OpenAPI.NET v3 — the rule description says exactly when to re-enable.js-yaml ^4.2.0 → ^5.0.0 (#425) — declined
overridessecurity floor from the deps: dashboard dependency sweep — npm audit (vite 8.1.0, js-yaml ≥4.2.0) + @vitejs/plugin-react 6.0.2 #406 audit sweep.openapi-typescript → @redocly/openapi-core,shadcn → cosmiconfig) declares^4.xand resolves 4.3.0 naturally;npm audit: 0 vulnerabilities.quoteStyle/forceQuotesdump API) into thegenerate:tsand shadcn toolchain for zero security gain. The floor should follow consumers into v5, not lead them.Both renovate PRs will be closed with a comment linking here once this merges.
Verification
renovate.jsonschema-valid (packageRules with matchDepNames/matchUpdateTypes).internal/qyl.instrumentationbuilds 0 errors on main afterward.🤖 Generated with Claude Code