deps: bump MCP 1.2 -> 1.3 + e2e bootstrap by ANcpLua · Pull Request #347 · ANcpLua/qyl

ANcpLua · 2026-05-17T06:17:59Z

Summary

Combines two pieces of work into one PR per request:

deps — Bumps ModelContextProtocol / ModelContextProtocol.Core / ModelContextProtocol.AspNetCore from 1.2.0 to 1.3.0.
tests/e2e — Folds in the auto-e2e-2026-05-17 bootstrap PR (new tests/qyl.e2e.tests project + E2ETests Nuke target + WireMock/Testcontainers package pins).

MCP 1.2 -> 1.3 behavior change

MCP 1.3 changes how transport failures surface from McpClient.CreateAsync:

SSE/HTTP connect failures now throw IOException (specifically the new public ClientTransportClosedException, which derives from IOException) rather than InvalidOperationException.
Caller-triggered OperationCanceledException is no longer wrapped.

In qyl, only one caller is affected: services/qyl.mcp/Tools/Debug/RiderMcpProxy.cs:59 (HttpClientTransport + StreamableHttp). The call site itself needs no change — error handling is downstream in ErrorFormatter.

ErrorFormatter update

services/qyl.mcp/Formatting/ErrorFormatter.cs pattern-matched InvalidOperationException as "Configuration Error". With 1.2, that arm caught transport connect failures (which were wrapped as InvalidOperationException) and mislabeled them. With 1.3 they bypass that arm and fall through to FormatUnknown — less useful for the LLM.

Added an IOException arm before InvalidOperationException (order matters in C# pattern switches) that formats transport-closed failures as "Connection Error" with a transport-mode-aware hint. This both (a) restores LLM-friendly messaging and (b) actually improves on the 1.2 behavior, where transport failures were being mislabeled as config errors.

Reference: https://github.com/modelcontextprotocol/csharp-sdk/releases/tag/v1.3.0

E2E bootstrap (from `tests/auto-e2e-2026-05-17`)

Infrastructure-only — no scenario tests yet. Adds:

tests/qyl.e2e.tests/ — new xUnit v3 / MTP project using WireMock.Net + Testcontainers
tests/qyl.e2e.tests/Topology/QylTopologyFixture.cs — programmatic Testcontainers topology (bridge network -> qyl-collector:latest -> qyl-mcp:latest); WireMock process-local, reached via host.docker.internal. WithImagePullPolicy(_ => false) enforces local-image-only.
tests/qyl.e2e.tests/Bootstrap/WireMockLlmSeamTests.cs — Category=E2EBootstrap smoke test (no Docker) proving the WireMock seam roundtrips.
eng/build/BuildTest.cs — new E2ETests Nuke target depending on IDocker.DockerImageBuild, filters Category=E2E. Default Test excludes Category=E2E but keeps E2EBootstrap.
Version.props + Directory.Packages.props — pinned WireMock.Net 2.6.0 and Testcontainers 4.11.0. Split-pinned OpenTelemetry.Instrumentation.AspNetCore to 1.15.2 (forced by WireMock.Net 2.6.0 transitive); Http and Runtime stay at the umbrella 1.15.1.

Merge conflict resolutions

Two conflicts when merging tests/auto-e2e-2026-05-17 into a branch off the latest origin/main:

.agents/routine-last-run.md — two routines (qyl-functional-tests and qyl-e2e-tests) wrote entries on the same day. Resolved by keeping both entries under the canonical ## <routine-name> YYYY-MM-DD HH:MM heading format from main.
eng/build/BuildTest.cs — main added a FunctionalTests target; auto-e2e added an E2ETests target. Both kept (they target different test scopes and are independent).

Test plan

dotnet restore qyl.slnx clean
dotnet build qyl.slnx --no-restore -> 0 errors, 19 pre-existing analyzer warnings (unrelated to changes)
nuke FunctionalTests (covered by main's pre-existing infrastructure)
nuke E2ETests not run in this PR — requires rebuilding all four qyl Docker images; out of scope for the bootstrap step. Next qyl-e2e-tests routine cycle will land the first scenario.
Verify the next qyl.mcp runtime call to McpClient.CreateAsync with a non-running endpoint produces the new "Connection Error" formatting rather than "Configuration Error".

Out of scope

The .NET SDK 10.0.300 + MSBuild SDKs 3.4.33/2.2.16 bump on the parallel deps/ancplua-sdk-bumps branch is not included here. It's a separate concern that can land on its own.
The dead claude/happy-kapitsa-3510e8 worktree was removed during prep (0 unique commits vs main, 0 file diffs, clean working tree).

🤖 Generated with Claude Code

First-run output of the qyl-e2e-tests routine — adds the infrastructure needed for the next cycle to land the first end-to-end scenario. - tests/qyl.e2e.tests: new xUnit v3 / MTP project with WireMock.Net + Testcontainers. Programmatic QylTopologyFixture spins up a bridge network, qyl-collector + qyl-mcp containers from local image tags, and a process-local WireMock the containers reach via host.docker.internal. WithImagePullPolicy(_ => false) enforces "test against fresh local builds (DockerImageBuild), never a registry tag". - WireMockLlmSeamTests (Category=E2EBootstrap, no Docker): proves the WireMock stub roundtrips a scripted /v1/chat/completions and surfaces in LogEntries. Ran 3x locally, 0 flakes, ~1s each. - eng/build/BuildTest.cs: new E2ETests Nuke target depending on IDocker.DockerImageBuild + filtering Category=E2E. Default Test target now also excludes Category=E2E (E2EBootstrap stays in). - Version.props + Directory.Packages.props: pin WireMock.Net 2.6.0 and Testcontainers 4.11.0. AspNetCore instrumentation split-pinned to 1.15.2 (forced by WireMock.Net 2.6.0 transitive); Http + Runtime stay at the umbrella 1.15.1 — no 1.15.2 release exists for them. - qyl.slnx: register the project. - .agents/routine-last-run.md: routine ledger update for 2026-05-17. No scenario tests here, per the skill's bootstrap section — scenario work waits until reviewers can verify the seams independently. Co-authored-by: Claude <noreply@anthropic.com>

…ootstrap # Conflicts: # .agents/routine-last-run.md # eng/build/BuildTest.cs

MCP 1.3 changes how transport failures surface from McpClient.CreateAsync: SSE/HTTP connect failures now throw IOException (via the new public ClientTransportClosedException, which derives from IOException) rather than InvalidOperationException. Caller-triggered OperationCanceledException is also no longer wrapped. services/qyl.mcp/Formatting/ErrorFormatter.cs: add an IOException arm before InvalidOperationException so transport-closed failures (including the new ClientTransportClosedException) format as "Connection Error" instead of falling through to FormatUnknown. Arm order matters — C# pattern switches dispatch top-down. Verified: dotnet build qyl.slnx --no-restore -> 0 errors. Ref: https://github.com/modelcontextprotocol/csharp-sdk/releases/tag/v1.3.0 Co-authored-by: Claude <noreply@anthropic.com>

Copilot

Pull request overview

Risk: Moderate — dependency bump plus new E2E harness plumbing; one confirmed topology bug will prevent the new E2E stack from working as intended.

Blockers

tests/qyl.e2e.tests/Topology/QylTopologyFixture.cs: MCP container port is wired to 5200, but the qyl-mcp image listens on 8080 by default (services/qyl.mcp/Dockerfile). This breaks port binding and makes McpBaseUrl incorrect. (Comment ID: 001)

Important issues

tests/qyl.e2e.tests/Topology/QylTopologyFixture.cs: WireMock is started and host.docker.internal is added, but the MCP container isn’t configured to use the WireMock endpoint (no QYL_AGENT_ENDPOINT/related config), so “deterministic LLM stubbing” won’t actually happen once topology tests are added. (Comment ID: 002)
eng/build/BuildTest.cs: E2ETests ignores MTP’s “no tests discovered” exit code (8) but has no post-run TRX guard, so the target can succeed while running zero E2E tests, masking misconfiguration/broken discovery. (Comment ID: 003)
Directory.Packages.props: OpenTelemetry.Instrumentation.AspNetCore is hard-pinned inline to 1.15.2 instead of being owned in Version.props like most other versions, which makes ongoing version management easier to drift. (Comment ID: 004)
services/qyl.mcp/Formatting/ErrorFormatter.cs: The PR description claims Rider MCP connect failures will be formatted via ErrorFormatter, but ErrorFormatter isn’t used on that path today; the new IOException arm may not produce the intended UX improvement unless the exception flow is wired accordingly. (Comment ID: 005)

Minor issues

None noted.

Changes:

Bump ModelContextProtocol packages from 1.2.0 → 1.3.0 and adjust error formatting.
Add an initial E2E test project + Docker/WireMock topology fixture scaffolding.
Add a Nuke E2ETests target and central-package pins for WireMock/Testcontainers.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
Version.props	Bumps MCP version; adds WireMock/Testcontainers version properties.
Directory.Packages.props	Pins WireMock/Testcontainers; adjusts OTel AspNetCore instrumentation pin.
services/qyl.mcp/Formatting/ErrorFormatter.cs	Adds `IOException` arm intended to improve transport-failure messaging.
eng/build/BuildTest.cs	Adds `E2ETests` Nuke target and excludes `Category=E2E` from default runs.
qyl.slnx	Registers the new `tests/qyl.e2e.tests` project.
tests/qyl.e2e.tests/qyl.e2e.tests.csproj	New xUnit v3/MTP E2E test project with WireMock + Testcontainers deps.
tests/qyl.e2e.tests/E2ECollection.cs	Defines a non-parallelized E2E collection using the topology fixture.
tests/qyl.e2e.tests/Bootstrap/WireMockLlmSeamTests.cs	Adds a WireMock-only bootstrap smoke test (no Docker).
tests/qyl.e2e.tests/Topology/QylTopologyOptions.cs	Adds basic topology options (image tags + timeout).
tests/qyl.e2e.tests/Topology/QylTopologyFixture.cs	Defines the Docker + WireMock topology fixture (currently has a port wiring bug).
.agents/routine-last-run.md	Records the new routine run / bootstrap PR handoff notes.

+public sealed class QylTopologyFixture : IAsyncLifetime
+{
+    private const int CollectorInternalPort = 5100;
+    private const int McpInternalPort = 5200;


+                .WithNetworkAliases("qyl-mcp")
+                .WithPortBinding(McpInternalPort, true)
+                .WithEnvironment("QYL_COLLECTOR_URL", $"http://qyl-collector:{CollectorInternalPort}")
+                .WithExtraHost("host.docker.internal", "host-gateway")
+                .WithWaitStrategy(Wait.ForUnixContainer()


+                var mtp = MtpExtensions.Mtp()
+                    .ReportTrx($"{project.Name}.E2E.trx")
+                    .IgnoreExitCode(8)
+                    .FilterTrait("Category", "E2E");
+


+         SDK version (1.15.3). AspNetCore is bumped to 1.15.2 because
+         WireMock.Net 2.6.0 (consumed by tests/qyl.e2e.tests) transitively
+         requires it; Http and Runtime have no 1.15.2 release, hence the split. -->
+    <PackageVersion Include="OpenTelemetry.Instrumentation.AspNetCore" Version="1.15.2"/>
    <PackageVersion Include="OpenTelemetry.Instrumentation.Http" Version="$(OpenTelemetryAspNetCoreInstrumentationVersion)"/>
    <PackageVersion Include="OpenTelemetry.Instrumentation.Runtime" Version="$(OpenTelemetryAspNetCoreInstrumentationVersion)"/>


+            // ModelContextProtocol 1.3 throws IOException (incl. ClientTransportClosedException)
+            // for transport connect/closure failures that 1.2 wrapped as InvalidOperationException.
+            // This arm must precede InvalidOperationException — order matters in C# pattern switches.
+            IOException ioEx => FormatTransportError(ioEx, transport),
            InvalidOperationException configEx => FormatConfigError(configEx, transport),
            _ => FormatUnknown(error, transport)


ANcpLua and others added 3 commits May 17, 2026 03:02

Merge branch 'tests/auto-e2e-2026-05-17' into deps/mcp-1.3-with-e2e-b…

6e2fa72

…ootstrap # Conflicts: # .agents/routine-last-run.md # eng/build/BuildTest.cs

Copilot AI review requested due to automatic review settings May 17, 2026 06:17

Copilot started reviewing on behalf of ANcpLua May 17, 2026 06:18 View session

Copilot AI reviewed May 17, 2026

View reviewed changes

ANcpLua merged commit ac337df into main May 17, 2026
9 of 16 checks passed

ANcpLua deleted the deps/mcp-1.3-with-e2e-bootstrap branch May 17, 2026 06:35

ANcpLua mentioned this pull request May 18, 2026

Auto E2E test run 2026-05-18 #353

Merged

Navigation Menu

deps: bump MCP 1.2 -> 1.3 + e2e bootstrap - #347

deps: bump MCP 1.2 -> 1.3 + e2e bootstrap#347
ANcpLua merged 3 commits into
mainfrom
deps/mcp-1.3-with-e2e-bootstrap

ANcpLua commented May 17, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

ANcpLua commented May 17, 2026

Summary

MCP 1.2 -> 1.3 behavior change

ErrorFormatter update

E2E bootstrap (from tests/auto-e2e-2026-05-17)

Merge conflict resolutions

Test plan

Out of scope

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Blockers

Important issues

Minor issues

Reviewed changes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

E2E bootstrap (from `tests/auto-e2e-2026-05-17`)