Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(exodia)!: collapse turbo-fix + fix-pipeline into one /exodia:fix (v3.0.0) #305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
feat(exodia)!: collapse turbo-fix + fix-pipeline into one /exodia:fix (v3.0.0) #305
Changes from all commits
f4d289f31d197eFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For users following this migration example for a P0, adding only
maximumafter the issue does not actually select maximum mode becausefixparses$1as severity and$2as parallelism (plugins/exodia/commands/fix.md:11-13)./exodia:fix "issue" maximumtherefore leaves$2at its defaultstandardand gives the workflow an invalid severity instead of the intended P0 maximum pipeline; the example should showP0 maximum.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the P0 case this example tells users to add only
maximum, butfix.mdstill treats$1as severity and$2as parallelism. A user following this as/exodia:fix "issue" maximumwill passmaximumas the severity and leave parallelism at the standard default, so the max-only agents described by the migration will not run; the example should showP0 maximum.Useful? React with 👍 / 👎.
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This expanded description promises auto-inheritance after an eight-gates run, but the eight-gates checkpoint path caches its merged findings with
session-state.sh artifact add "findings"(plugins/exodia/skills/eight-gates/templates/gate-04-checkpoint.mdline 22), which writes.eight-gates/artifacts/findings, not the.eight-gates/artifacts/findings.jsonfile thatfixreads. Users coming from eight-gates therefore get no injectedfix/filescontext and the consolidated command falls back to rediscovery.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This replacement points audit users at
/exodia:fix "[P0 issue]", but the consolidatedfixcommand still says to filter prior findings byfinding.idmatching$0(plugins/exodia/commands/fix.md:53), and the SessionStart index exposes ids separately from titles. In the common mega-swarm flow where the user copies the issue title from this report, the lookup will miss and the advertised auto-inheritance offix,files, andseveritywill not happen; either instruct users to pass the finding id or makefixmatch titles/scope too.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After a mega-swarm run, the persisted JSON includes an
idfor each finding, and/exodia:fixonly injects prior context whenfinding.idmatches$0(fix.mdline 53). This new handoff tells users to pass the rendered P0 issue title from the report table, which has no id column; in that scenario the match misses andfixre-discovers the issue instead of using the storedfix,files, and severity.Useful? React with 👍 / 👎.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.