chore: manual root-authority cleanup (admin merge, WIP) - #289
Merged
Merged
Conversation
… the plugin template Admin-authorized removal of files unused over the last ~2 weeks: - AGENTS.md, GEMINI.md (agent-config single source + one generated copy) - docs guides: ENGINEERING-PRINCIPLES, PLUGINS, QUICK-REFERENCE, WORKFLOWS, archive/CHANGELOG-history, research-2026-05-05-claude-code-stack - scripts/sync-from-anthropic.sh - the entire tooling/ tree: weave-validate.sh, sync-marketplace.sh, plugin-template/ Sync docs/ARCHITECTURE.md to the post-cleanup tree: drop the removed paths, repoint validation at CI (ci.yml) now the local weave-validate wrapper is gone, and drop AGENTS.md from the per-agent config table. Deletions are kept verbatim even where they break a reference — CLAUDE.md and the cursor/windsurf copies still cite the now-removed AGENTS.md single source. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR performs an admin-authorized cleanup by removing repository-level “tooling” scaffolding and several repo docs/config files judged unused, and then updates docs/ARCHITECTURE.md to reflect the resulting tree and validation approach.
Changes:
- Removed the entire
tooling/tree (scripts + plugin template scaffold). - Removed
AGENTS.md,GEMINI.md, multipledocs/*.mdguides, and one rootscripts/helper. - Updated
docs/ARCHITECTURE.mdto drop removed paths and reframe validation around CI.
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tooling/templates/plugin-template/skills/example-skill/SKILL.md | Deleted plugin-template example skill scaffold |
| tooling/templates/plugin-template/README.md | Deleted plugin-template README scaffold |
| tooling/templates/plugin-template/hooks/hooks.json | Deleted plugin-template hooks scaffold |
| tooling/templates/plugin-template/commands/example-command.md | Deleted plugin-template command scaffold |
| tooling/templates/plugin-template/CLAUDE.md | Deleted plugin-template CLAUDE.md scaffold |
| tooling/templates/plugin-template/.claude-plugin/plugin.json | Deleted plugin-template manifest scaffold |
| tooling/scripts/weave-validate.sh | Deleted repo-wide local validation wrapper |
| tooling/scripts/sync-marketplace.sh | Deleted marketplace sync helper |
| scripts/sync-from-anthropic.sh | Deleted Anthropic upstream sync helper script |
| GEMINI.md | Deleted Gemini agent guidance copy |
| docs/WORKFLOWS.md | Deleted workflows/validation guide |
| docs/research-2026-05-05-claude-code-stack.md | Deleted research notes document |
| docs/QUICK-REFERENCE.md | Deleted quick reference guide |
| docs/PLUGINS.md | Deleted plugin creation/installation guide |
| docs/ENGINEERING-PRINCIPLES.md | Deleted engineering principles narrative doc |
| docs/archive/CHANGELOG-history.md | Deleted archived changelog history |
| docs/ARCHITECTURE.md | Updated architecture doc to reflect removals and CI-based validation |
| AGENTS.md | Deleted agent operating guide (SSOT) |
Comment on lines
149
to
153
| | Stage | Tool | Purpose | | ||
| |-------|------|---------| | ||
| | Local | `weave-validate.sh` | Pre-commit checks | | ||
| | CI | `ci.yml` | Automated validation | | ||
| | Review | `claude-code-review.yml` | AI-assisted review | | ||
| | Merge | `auto-merge.yml` | Tiered auto-merge | |
Comment on lines
+109
to
+111
| Validation runs in CI via `.github/workflows/ci.yml`. The former local wrapper | ||
| `tooling/scripts/weave-validate.sh` was removed in the manual cleanup; run the gate | ||
| tools below directly, or rely on CI. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3bf6c12a61
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1,207 +0,0 @@ | |||
| <!-- | |||
There was a problem hiding this comment.
When the TomeVault publish/dry-run path is used, this deletion leaves .tome/tome.yaml pointing at AGENTS.md as configs[0] and rendering the other agent config targets from that same input (.tome/tome.yaml lines 26-43), so the manifest no longer has the source file it needs and the publish/regeneration pipeline will fail before producing CLAUDE.md, GEMINI.md, Cursor, or Windsurf configs. Either keep AGENTS.md or update/remove the TomeVault manifest in the same change.
Useful? React with 👍 / 👎.
| @@ -1,210 +0,0 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
Copilot's repo instructions still require ./tooling/scripts/weave-validate.sh before completion and when adding plugins (.github/copilot-instructions.md lines 26, 216, and 265), so deleting this entrypoint means future Copilot-authored work following the checked-in guidance will hit a missing command instead of running validation. Either keep the wrapper or update the Copilot workflow instructions to the direct replacement commands in this same cleanup.
Useful? React with 👍 / 👎.
Comment on lines
+109
to
+111
| Validation runs in CI via `.github/workflows/ci.yml`. The former local wrapper | ||
| `tooling/scripts/weave-validate.sh` was removed in the manual cleanup; run the gate | ||
| tools below directly, or rely on CI. |
There was a problem hiding this comment.
After the local wrapper is removed, this tells maintainers to rely on CI, but .github/workflows/ci.yml never runs claude plugin validate and no longer performs the marketplace ↔ plugin.json version-sync check that the deleted wrapper treated as hard failures. In the environment where contributors follow this new guidance, malformed plugin manifests or version drift can now pass CI, so either port those checks into CI or avoid presenting CI as the replacement gate.
Useful? React with 👍 / 👎.
This was referenced Jun 6, 2026
ANcpLua
added a commit
that referenced
this pull request
Jun 9, 2026
…md is canonical (#299) AGENTS.md and GEMINI.md were deleted in #289 (root-authority cleanup), but ~6 carriers still routed every editor and the Codex review bot to those now-missing files, on surfaces loaded every session. The "Edit AGENTS.md only; regenerate via npx tomevault init" banner was a lie: no AGENTS.md, no GEMINI.md, and no TomeVault renderer is installed. Promote CLAUDE.md to canonical (the only carrier present at HEAD, auto-loaded by Claude Code): - rewrite the single-source banner in CLAUDE.md, .cursor/rules/project-config.mdc, and .windsurf/rules/project-config.md to name CLAUDE.md canonical, with .cursor/.windsurf as hand-maintained copies - drop the AGENTS.md tree line + the AGENTS.md repo-context reference in .github/copilot-instructions.md - repoint .github/codex/prompts/review.md at README.md + CLAUDE.md - rewrite .tome/tome.yaml: CLAUDE.md as the config source, every file shipped verbatim (no renderer installed), AGENTS.md/GEMINI.md render targets removed; also fixed the pre-existing invalid YAML (unquoted configs[N] inside a flow mapping) The #289 deletion was deliberate and is final; restoring AGENTS.md would resurrect an editorial apparatus with no working generator. Legit mentions of the AGENTS.md *concept* (tomevault-publish skill, metacognitive-guard's anti-AGENTS.md-in-plugins guard, charon's "stale AGENTS.md not authority" doctrine, changelog/spec history) are left untouched. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ANcpLua
added a commit
that referenced
this pull request
Jun 11, 2026
…/workflows + refresh counts/CHANGELOG (#311) * docs: derot hygiene sweep — purge dead refs to deleted tooling/config/workflows + refresh counts/CHANGELOG Four read-only rot-scouts verified every item against ground truth (13 plugins / 24 commands / 24 skills / 30 agents, excluding cc-plugin-eval/fixtures). This applies the corrected values so the docs describe the repo that actually exists at HEAD. What was contradicting reality, now fixed: docs/ARCHITECTURE.md - Count comment 9/22/14/21 → 13/24/24/30; "7 custom plugins" → 13; plugin tree gains charon, derot, nihil, tomevault-publish (alphabetical, └── closes the box). - Drop dead config lines: .coderabbit.yaml (no such file) and .markdownlint.json (actual name is .markdownlint.jsonc). - .claude/ tree now reflects disk: commands/ rules/ workflows/ worktrees/ — not settings.json; rules/ holds the Opus 4.8 System Card PDF, not "auto-loaded rules". - workflows/ listed the two non-existent CodeRabbit/Codex YAMLs; real set is auto-merge.yml, ci.yml, claude.yml. - Delete dangling pointers to files that do not exist: solid-principles.md, devops-calms.md, and the "CLAUDE.md Section 5.5.1" cross-reference; remove the weave-validate.sh wrapper mention (tooling/ was deleted). claude-code-review.yml → claude.yml. Last Verified 2026-06-06 → 2026-06-11. docs/decisions/ADR-0001 - "tooling/ and docs/" → "docs/" (tooling/ removed); spec.md (never existed) → the docs/specs/ documents, in all three places it was cited. .github/copilot-instructions.md - Replace every weave-validate.sh / tooling/ reference with the real gate: validation is ci.yml (inline jq for JSON syntax + plugin.json/marketplace.json fields + source-dir existence + SKILL.md frontmatter, shellcheck, markdownlint, actionlint). - Structure tree: 3-plugin enumeration (exodia tagged v2.0.0) → "13 plugins — see marketplace.json"; dependabot.yml moved to .github/ (it is not under workflows/); .claude/rules/ note corrected; auto-merge.yml + claude.yml added; tooling/ subtree deleted. claude-code-review.yml → claude.yml on @claude mentions. README.md - "GitHub review automation" named codex-code-review.yml + OPENAI_API_KEY, neither of which exists. Rewritten to reality: auto-merge.yml recognizes codex/ + copilot/ branches and chatgpt-codex-connector[bot] approvals; claude.yml runs on @claude. plugins/cc-plugin-eval/README.md - Illustrative marketplace snippet version 0.1.0 → 0.2.0 (matches plugin.json + marketplace.json). CHANGELOG.md - [Unreleased] gains the #286–#310 wave (each entry grounded against git log + current plugin.json): charon 0.1.0→0.2.1, derot 0.2.0 (+/depmigrate), nihil 0.3.0 (/nihil:raze), tomevault-publish 0.1.0, cc-plugin-eval CC710 0.2.0; exodia 3.x /exodia:fix collapse; and the #289/#299 removal of the AGENTS.md/GEMINI.md single-source model (CLAUDE.md is now canonical). Left untouched on purpose: docs/specs/spec-0004 (Status: Parked — frozen snapshot), README's "Tri-AI … CodeRabbit" line (CodeRabbit unverified, flagged for human), and tome.json (generated by the TomeVault crawler). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * docs(architecture): restore .coderabbit.yaml refs — file landed on main via #313 after this branch was cut Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Admin-authorized manual cleanup. Removes files judged unused over the last ~2 weeks and syncs
docs/ARCHITECTURE.mdto the resulting tree.AGENTS.md,GEMINI.md;docs/guides (ENGINEERING-PRINCIPLES, PLUGINS, QUICK-REFERENCE, WORKFLOWS),docs/archive/CHANGELOG-history.md,docs/research-2026-05-05-claude-code-stack.md;scripts/sync-from-anthropic.sh; the entiretooling/tree (weave-validate.sh,sync-marketplace.sh,plugin-template/).docs/ARCHITECTURE.md— drop removed paths, repoint validation at CI, dropAGENTS.mdfrom the per-agent config table.plugins/*(out of scope).Notes
CLAUDE.mdand the cursor/windsurf copies still reference the now-removedAGENTS.mdsingle source. Accepted by root authority.--adminper directive.Test Plan
git statusclean after commit; only intended 17 deletions + 1 doc edit stagedplugins/*files modified