docs: update CLAUDE.md for 2.1.80 migration - #183
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
Cache: Disabled due to data retention organization setting Knowledge base: Disabled due to data retention organization setting Summary by CodeRabbitRelease Notes
WalkthroughCLAUDE.md updated with revised plugin version synchronization requirements, CI agent workflow behavior, expanded auto-merge tiers for AI agents, coordination/merge policies, CODEOWNERS automation, and new frontmatter capability for skill effort levels. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
📝 Coding Plan
Comment |
There was a problem hiding this comment.
Code Review
This pull request updates the CLAUDE.md documentation to align with recent process changes. The updates include enforcing marketplace version synchronization, describing the new review-fix loop, adding Codex to the AI review team, and clarifying auto-merge tiers. The changes are clear and improve the documentation, but I found one minor inconsistency that was introduced.
| | Copilot | Yes | Yes (Coding Agent) | No | | ||
| | CodeRabbit | Yes | No | No | | ||
| | CodeRabbit | Yes | No | Yes (tier 3a) | | ||
| | Codex | Yes | No | Yes (tier 3c) | |
There was a problem hiding this comment.
Pull request overview
Updates CLAUDE.md to reflect the repository’s current automation and process expectations during the 2.1.80 migration period, including version-sync enforcement and AI review/auto-merge behavior.
Changes:
- Documented hard-fail enforcement for plugin version parity between
.claude-plugin/marketplace.jsonand each plugin’s.claude-plugin/plugin.json. - Expanded the CI agent description and clarified the “review-fix loop” workflow behavior.
- Updated Tri-AI/automation sections to include Codex and revised auto-merge tier descriptions; added
effort:frontmatter guidance.
| @@ -25,14 +26,17 @@ Three autonomous AIs review every PR independently: Claude, Copilot, CodeRabbit. | |||
|
|
|||
There was a problem hiding this comment.
The section title/sentence still says "Tri-AI" / "Three autonomous AIs" but the table now includes Codex as a 4th reviewer. Update the wording (and potentially the heading) so it matches the current set of agents listed below.
|
|
||
| Auto-merge tiers: Dependabot patch/minor -> Copilot fix+CI -> Claude fix+CI+1 approval -> human review. | ||
| Auto-merge tiers (see `auto-merge.yml`): Dependabot/Renovate patch+minor → AI agent branches (copilot/, claude/) → CodeRabbit/Claude/Codex approved. | ||
| Only required check: GitGuardian. All AI reviews are advisory. |
There was a problem hiding this comment.
"Only required check: GitGuardian" appears to be unsupported by the repo configuration: there are no references to GitGuardian anywhere else in the repository, and CI defines multiple checks (JSON/plugin validation, ShellCheck, Markdownlint, actionlint). Consider rephrasing to avoid implying CI failures can be ignored (e.g., distinguish branch-protection required checks vs. expected CI status checks).
| Only required check: GitGuardian. All AI reviews are advisory. | |
| Branch protection may enforce specific required status checks (see repository settings). All CI checks (see `.github/workflows/ci.yml`) must pass; AI reviews are advisory. |
| <changelog-mandate> | ||
| Update CHANGELOG.md under `## [Unreleased]` before committing. No exceptions. | ||
| When modifying a plugin, bump `plugins/<name>/.claude-plugin/plugin.json` version. | ||
| When modifying a plugin, bump `plugins/<name>/.claude-plugin/plugin.json` version AND sync marketplace.json. |
There was a problem hiding this comment.
In the changelog mandate, "sync marketplace.json" is a bit ambiguous—this repo’s manifest lives at .claude-plugin/marketplace.json (as referenced by weave-validate.sh). Consider using the full path here to reduce the chance of syncing the wrong file.
| When modifying a plugin, bump `plugins/<name>/.claude-plugin/plugin.json` version AND sync marketplace.json. | |
| When modifying a plugin, bump `plugins/<name>/.claude-plugin/plugin.json` version AND sync `.claude-plugin/marketplace.json`. |
Syncs CLAUDE.md with changes from this session: