Add core.slnf — solution filter without demo projects - #18
Conversation
Opening the full slnx loads all 39 projects (30 demos) -> Rider perma-lags. core.slnf is a solution filter over the canonical .slnx that loads only the 9 core projects (src + benchmark + test fixture). Same pattern as MAF's agent-framework-release.slnf. No demos, no duplicated solution. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📜 Recent review details⏰ Context from checks skipped due to timeout. (1)
🧰 Additional context used📓 Path-based instructions (1)**⚙️ CodeRabbit configuration file
Files:
⚙️ CodeRabbit configuration file
Files:
🔇 Additional comments (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughA new solution-filter file ChangesCore Solution Filter
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
…ft, sync to v4.0.0 QylInstrumentation.Version was a hardcoded const "0.3.0-pre.1" stamped onto every emitted span/metric via QylActivitySource, while the package now ships as v4.0.0. Props floor said 3.0.2, README said 0.3.0-pre.1, and the OTLP verified fixture said 3.0.2 — four version stories, none matching what the runtime actually emitted. Root fix (single source of truth; reflection-free, per the contract-invariants gate): - New GenerateQylVersionInfo MSBuild target bakes <Version> into a generated internal const (QylVersionInfo.Version) that QylInstrumentation.Version references. No System.Reflection (banned in product code by verify-contract-invariants.py). Always regenerates, so a CI -p:Version override is honoured. const -> static readonly; PublicAPI baseline updated. - Directory.Build.props <Version> floor -> 4.0.0 (matches the released v4.0.0 tag); CI-owned. - README install examples -> 4.0.0. - CHANGELOG: added [4.0.0] (IStartupFilter refactor #20 + core.slnf #18); the version- derivation change sits under [Unreleased]. - Regenerated the OTLP verified fixture to 4.0.0 — it now matches the runtime scope version, which it never did before (fixture rendered 3.0.2 while the runtime const emitted 0.3.0-pre.1). Drift-proofing: - tools/verify-version-sync.py (in the no-Docker floor) asserts props floor >= latest v* tag, README examples == floor, and the version stays generated-const-derived (no literal). Negative-tested. Verified: the FULL no-Docker validation floor passes locally (contract invariants, release build, public API, version sync, generator snapshots, source interceptor, otlp verified fixtures, nativeaot consumer verified — all green). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ft, sync to v4.0.0 (#21) QylInstrumentation.Version was a hardcoded const "0.3.0-pre.1" stamped onto every emitted span/metric via QylActivitySource, while the package now ships as v4.0.0. Props floor said 3.0.2, README said 0.3.0-pre.1, and the OTLP verified fixture said 3.0.2 — four version stories, none matching what the runtime actually emitted. Root fix (single source of truth; reflection-free, per the contract-invariants gate): - New GenerateQylVersionInfo MSBuild target bakes <Version> into a generated internal const (QylVersionInfo.Version) that QylInstrumentation.Version references. No System.Reflection (banned in product code by verify-contract-invariants.py). Always regenerates, so a CI -p:Version override is honoured. const -> static readonly; PublicAPI baseline updated. - Directory.Build.props <Version> floor -> 4.0.0 (matches the released v4.0.0 tag); CI-owned. - README install examples -> 4.0.0. - CHANGELOG: added [4.0.0] (IStartupFilter refactor #20 + core.slnf #18); the version- derivation change sits under [Unreleased]. - Regenerated the OTLP verified fixture to 4.0.0 — it now matches the runtime scope version, which it never did before (fixture rendered 3.0.2 while the runtime const emitted 0.3.0-pre.1). Drift-proofing: - tools/verify-version-sync.py (in the no-Docker floor) asserts props floor >= latest v* tag, README examples == floor, and the version stays generated-const-derived (no literal). Negative-tested. Verified: the FULL no-Docker validation floor passes locally (contract invariants, release build, public API, version sync, generator snapshots, source interceptor, otlp verified fixtures, nativeaot consumer verified — all green). Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Why
Opening the full
.slnxloads all 39 projects (30demos/), making Rider perma-lag/freeze (thread dumps show AWT-EventQueue stalls).What
Qyl.OpenTelemetry.AutoInstrumentation-core.slnf— a solution filter over the.slnxthat loads only the 9 core projects (7src/+ benchmark + test fixture). Zero demos. It's a view over the real solution, so it never drifts.core.slnf→ 9 projects, no lag..slnx(all 39).Additive only.
🤖 Generated with Claude Code