docs(agents): add ecosystem table - #83
Conversation
…ncy graph Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
There was a problem hiding this comment.
Pull request overview
Adds an “ANcpLua Ecosystem” reference section to AGENTS.md to document the related repositories, their NuGet packages, CI requirements, branch protection expectations, dependency relationships, and the release flow.
Changes:
- Added an ecosystem table covering 4 repos with links, purpose summaries, NuGet links, and required CI checks.
- Documented shared branch protection rules across the ecosystem repos.
- Added a dependency graph and a short release flow checklist.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Code Review
This pull request updates AGENTS.md to document the ANcpLua ecosystem, including repository purposes, branch protection policies, dependency graphs, and release flows. The review identified two inaccuracies: the CI checks for ANcpLua.Roslyn.Utilities should include macOS for cross-platform consistency, and the dependency graph incorrectly labels ANcpLua.Agents as standalone despite its dependency on ANcpLua.Roslyn.Utilities.
| |---|---|---|---| | ||
| | [ANcpLua.NET.Sdk](https://github.com/ANcpLua/ANcpLua.NET.Sdk) | Opinionated MSBuild SDK — standardized defaults, policy enforcement, analyzer injection | [nuget.org](https://www.nuget.org/packages/ANcpLua.NET.Sdk) | `compute_version`, `lint_config`, `test (ubuntu/windows/macos)`, `create_nuget` | | ||
| | [ANcpLua.Analyzers](https://github.com/ANcpLua/ANcpLua.Analyzers) | Custom Roslyn analyzers (auto-injected by the SDK) | [nuget.org](https://www.nuget.org/packages/ANcpLua.Analyzers) | `build`, `test (ubuntu/windows/macos)` | | ||
| | [ANcpLua.Roslyn.Utilities](https://github.com/ANcpLua/ANcpLua.Roslyn.Utilities) | Source generator utilities, TryParse extensions, polyfills | [nuget.org](https://www.nuget.org/packages/ANcpLua.Roslyn.Utilities) | `build (ubuntu/windows)`, `version` | |
There was a problem hiding this comment.
The CI checks for ANcpLua.Roslyn.Utilities are missing macos, whereas the other repositories in the ecosystem (including the downstream ANcpLua.Agents) include it. Since this is a cross-platform utility library, it should likely be built and verified on all three platforms for consistency.
| | [ANcpLua.Roslyn.Utilities](https://github.com/ANcpLua/ANcpLua.Roslyn.Utilities) | Source generator utilities, TryParse extensions, polyfills | [nuget.org](https://www.nuget.org/packages/ANcpLua.Roslyn.Utilities) | `build (ubuntu/windows)`, `version` | | |
| | [ANcpLua.Roslyn.Utilities](https://github.com/ANcpLua/ANcpLua.Roslyn.Utilities) | Source generator utilities, TryParse extensions, polyfills | [nuget.org](https://www.nuget.org/packages/ANcpLua.Roslyn.Utilities) | `build (ubuntu/windows/macos)`, `version` | |
| └── standalone (no first-party deps) | ||
|
|
||
| ANcpLua.Agents | ||
| └── standalone (no first-party deps) |
There was a problem hiding this comment.
The dependency graph describes ANcpLua.Agents as standalone, but this contradicts line 7 and line 21, which state that it consumes ANcpLua.Roslyn.Utilities. It also conflicts with the bootstrap chain mentioned in line 34. The graph should be updated to show this dependency.
| └── standalone (no first-party deps) | |
| └── consumes ANcpLua.Roslyn.Utilities |
Adds cross-repo ecosystem reference with NuGet links, required CI checks, branch protection rules, dependency graph, and release flow.