Skip to content

fix: remove Workspaces dependency from core package #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ANcpLua merged 1 commit into from
Feb 7, 2026
Merged

fix: remove Workspaces dependency from core package #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...tilities/CodeFixes/CodeFixProviderBase.cs → ....Testing/CodeFixes/CodeFixProviderBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
using System.Collections.Immutable;

@gemini-code-assist gemini-code-assist Bot Feb 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with the established project style, consider making this a global using. Both the source project (ANcpLua.Roslyn.Utilities) and the destination project (ANcpLua.Roslyn.Utilities.Testing) use global usings. Instead of adding an explicit using here, you could add <Using Include="System.Collections.Immutable"/> to ANcpLua.Roslyn.Utilities.Testing.csproj. This would maintain a consistent approach to dependency management across projects and keep the code cleaner.

using System.Threading.Tasks;
using Microsoft.CodeAnalysis;
using Microsoft.CodeAnalysis.CodeActions;
Expand Down
0 ...ies/CodeFixes/SyntaxModifierExtensions.cs → ...ing/CodeFixes/SyntaxModifierExtensions.cs
View file
Open in desktop
File renamed without changes.
1 change: 0 additions & 1 deletion ANcpLua.Roslyn.Utilities/ANcpLua.Roslyn.Utilities/ANcpLua.Roslyn.Utilities.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@
<ItemGroup>
<PackageReference Include="Microsoft.Bcl.HashCode"/>
<PackageReference Include="Microsoft.CodeAnalysis.CSharp"/>
<PackageReference Include="Microsoft.CodeAnalysis.Workspaces.Common"/>
</ItemGroup>

<ItemGroup>
Expand Down
Loading