Repository navigation
refactor: split oversized utility files + reduce cyclomatic complexity - #127
93 new issues (0 max.) of at least severity.
Here is an overview of what got changed by this pull request:
Issues
======
+ Solved 89
- Added 93
Complexity increasing per file
==============================
- src/ANcpLua.Roslyn.Utilities/SymbolExtensions.Attributes.cs 29
- src/ANcpLua.Roslyn.Utilities/SymbolExtensions.Interfaces.cs 7
- src/ANcpLua.Roslyn.Utilities/SymbolExtensions.Members.cs 14
- src/ANcpLua.Roslyn.Utilities/SymbolExtensions.Misc.cs 9
- src/ANcpLua.Roslyn.Utilities/SymbolExtensions.TypeParameters.cs 6
- src/ANcpLua.Roslyn.Utilities/TypeSymbolExtensions.CodeGen.cs 5
- src/ANcpLua.Roslyn.Utilities/TypeSymbolExtensions.FrameworkTypes.cs 19
- src/ANcpLua.Roslyn.Utilities/TypeSymbolExtensions.Members.cs 7
- src/ANcpLua.Roslyn.Utilities/TypeSymbolExtensions.Nullable.cs 6
- src/ANcpLua.Roslyn.Utilities/TypeSymbolExtensions.SpecialTypes.cs 8
- src/ANcpLua.Roslyn.Utilities/TypeSymbolExtensions.TestClass.cs 26
Complexity decreasing per file
==============================
+ src/ANcpLua.Roslyn.Utilities/SymbolExtensions.cs -77
+ src/ANcpLua.Roslyn.Utilities/TypeSymbolExtensions.cs -100
Clones removed
==============
+ src/ANcpLua.Roslyn.Utilities/SymbolExtensions.cs -5
See the complete overview on Codacy
Annotations
Check notice on line 10 in src/ANcpLua.Roslyn.Utilities/StringExtensions.Hashing.cs
codacy-production / Codacy Static Code Analysis
src/ANcpLua.Roslyn.Utilities/StringExtensions.Hashing.cs#L10
'partial' is gratuitous in this context.
Check notice on line 56 in src/ANcpLua.Roslyn.Utilities/StringExtensions.Hashing.cs
codacy-production / Codacy Static Code Analysis
src/ANcpLua.Roslyn.Utilities/StringExtensions.Hashing.cs#L56
Add curly braces around the nested statement(s) in this 'if' block.
Check notice on line 59 in src/ANcpLua.Roslyn.Utilities/StringExtensions.Hashing.cs
codacy-production / Codacy Static Code Analysis
src/ANcpLua.Roslyn.Utilities/StringExtensions.Hashing.cs#L59
Add curly braces around the nested statement(s) in this 'if' block.
Check notice on line 63 in src/ANcpLua.Roslyn.Utilities/StringExtensions.Hashing.cs
codacy-production / Codacy Static Code Analysis
src/ANcpLua.Roslyn.Utilities/StringExtensions.Hashing.cs#L63
Add curly braces around the nested statement(s) in this 'if' block.
Check notice on line 8 in src/ANcpLua.Roslyn.Utilities/StringExtensions.Identifiers.cs
codacy-production / Codacy Static Code Analysis
src/ANcpLua.Roslyn.Utilities/StringExtensions.Identifiers.cs#L8
'partial' is gratuitous in this context.
Check notice on line 49 in src/ANcpLua.Roslyn.Utilities/StringExtensions.Identifiers.cs
codacy-production / Codacy Static Code Analysis
src/ANcpLua.Roslyn.Utilities/StringExtensions.Identifiers.cs#L49
Add curly braces around the nested statement(s) in this 'if' block.
Check notice on line 52 in src/ANcpLua.Roslyn.Utilities/StringExtensions.Identifiers.cs
codacy-production / Codacy Static Code Analysis
src/ANcpLua.Roslyn.Utilities/StringExtensions.Identifiers.cs#L52
Add curly braces around the nested statement(s) in this 'if' block.
Check notice on line 93 in src/ANcpLua.Roslyn.Utilities/StringExtensions.Identifiers.cs
codacy-production / Codacy Static Code Analysis
src/ANcpLua.Roslyn.Utilities/StringExtensions.Identifiers.cs#L93
Add curly braces around the nested statement(s) in this 'if' block.
Check notice on line 110 in src/ANcpLua.Roslyn.Utilities/StringExtensions.Identifiers.cs
codacy-production / Codacy Static Code Analysis
src/ANcpLua.Roslyn.Utilities/StringExtensions.Identifiers.cs#L110
Add curly braces around the nested statement(s) in this 'if' block.
Check notice on line 113 in src/ANcpLua.Roslyn.Utilities/StringExtensions.Identifiers.cs
codacy-production / Codacy Static Code Analysis
src/ANcpLua.Roslyn.Utilities/StringExtensions.Identifiers.cs#L113
Add curly braces around the nested statement(s) in this 'foreach' block.
Check notice on line 128 in src/ANcpLua.Roslyn.Utilities/StringExtensions.Identifiers.cs
codacy-production / Codacy Static Code Analysis
src/ANcpLua.Roslyn.Utilities/StringExtensions.Identifiers.cs#L128
Add curly braces around the nested statement(s) in this 'if' block.
Check notice on line 8 in src/ANcpLua.Roslyn.Utilities/StringExtensions.Quoting.cs
codacy-production / Codacy Static Code Analysis
src/ANcpLua.Roslyn.Utilities/StringExtensions.Quoting.cs#L8
'partial' is gratuitous in this context.
Check notice on line 137 in src/ANcpLua.Roslyn.Utilities/StringExtensions.Quoting.cs
codacy-production / Codacy Static Code Analysis
src/ANcpLua.Roslyn.Utilities/StringExtensions.Quoting.cs#L137
Add curly braces around the nested statement(s) in this 'if' block.
Check notice on line 140 in src/ANcpLua.Roslyn.Utilities/StringExtensions.Quoting.cs
codacy-production / Codacy Static Code Analysis
src/ANcpLua.Roslyn.Utilities/StringExtensions.Quoting.cs#L140
Add curly braces around the nested statement(s) in this 'if' block.
Check notice on line 146 in src/ANcpLua.Roslyn.Utilities/StringExtensions.Quoting.cs
codacy-production / Codacy Static Code Analysis
src/ANcpLua.Roslyn.Utilities/StringExtensions.Quoting.cs#L146
Rename the parameter 'quote' so that it does not duplicate the method name.
Check notice on line 8 in src/ANcpLua.Roslyn.Utilities/StringExtensions.TypeNames.cs
codacy-production / Codacy Static Code Analysis
src/ANcpLua.Roslyn.Utilities/StringExtensions.TypeNames.cs#L8
'partial' is gratuitous in this context.
Check notice on line 65 in src/ANcpLua.Roslyn.Utilities/StringExtensions.TypeNames.cs
codacy-production / Codacy Static Code Analysis
src/ANcpLua.Roslyn.Utilities/StringExtensions.TypeNames.cs#L65
Add curly braces around the nested statement(s) in this 'if' block.
Check notice on line 79 in src/ANcpLua.Roslyn.Utilities/StringExtensions.TypeNames.cs
codacy-production / Codacy Static Code Analysis
src/ANcpLua.Roslyn.Utilities/StringExtensions.TypeNames.cs#L79
Add curly braces around the nested statement(s) in this 'if' block.
Check notice on line 82 in src/ANcpLua.Roslyn.Utilities/StringExtensions.TypeNames.cs
codacy-production / Codacy Static Code Analysis
src/ANcpLua.Roslyn.Utilities/StringExtensions.TypeNames.cs#L82
Add curly braces around the nested statement(s) in this 'if' block.
Check notice on line 86 in src/ANcpLua.Roslyn.Utilities/StringExtensions.TypeNames.cs
codacy-production / Codacy Static Code Analysis
src/ANcpLua.Roslyn.Utilities/StringExtensions.TypeNames.cs#L86
Add curly braces around the nested statement(s) in this 'if' block.
Check notice on line 111 in src/ANcpLua.Roslyn.Utilities/StringExtensions.TypeNames.cs
codacy-production / Codacy Static Code Analysis
src/ANcpLua.Roslyn.Utilities/StringExtensions.TypeNames.cs#L111
Add curly braces around the nested statement(s) in this 'if' block.
Check notice on line 10 in src/ANcpLua.Roslyn.Utilities/StringExtensions.Whitespace.cs
codacy-production / Codacy Static Code Analysis
src/ANcpLua.Roslyn.Utilities/StringExtensions.Whitespace.cs#L10
'partial' is gratuitous in this context.
Check notice on line 55 in src/ANcpLua.Roslyn.Utilities/StringExtensions.Whitespace.cs
codacy-production / Codacy Static Code Analysis
src/ANcpLua.Roslyn.Utilities/StringExtensions.Whitespace.cs#L55
Add curly braces around the nested statement(s) in this 'foreach' block.
Check notice on line 58 in src/ANcpLua.Roslyn.Utilities/StringExtensions.Whitespace.cs
codacy-production / Codacy Static Code Analysis
src/ANcpLua.Roslyn.Utilities/StringExtensions.Whitespace.cs#L58
Add curly braces around the nested statement(s) in this 'if' block.
Check notice on line 69 in src/ANcpLua.Roslyn.Utilities/StringExtensions.Whitespace.cs
codacy-production / Codacy Static Code Analysis
src/ANcpLua.Roslyn.Utilities/StringExtensions.Whitespace.cs#L69
Add curly braces around the nested statement(s) in this 'if' block.