Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Version.props
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
ROSLYN.UTILITIES (Runtime package)
═══════════════════════════════════════════════════════════════════════ -->
<PropertyGroup Label="Roslyn.Utilities">
<ANcpLuaRoslynUtilitiesVersion>1.30.2</ANcpLuaRoslynUtilitiesVersion>
<ANcpLuaRoslynUtilitiesVersion>1.31.0</ANcpLuaRoslynUtilitiesVersion>
</PropertyGroup>

<!-- ═══════════════════════════════════════════════════════════════════════
Expand All @@ -46,7 +46,7 @@
ROSLYN.UTILITIES.TESTING (Analyzer/CodeFix/Generator test infrastructure)
═══════════════════════════════════════════════════════════════════════ -->
<PropertyGroup Label="Roslyn.Utilities.Testing">
<ANcpLuaRoslynUtilitiesTestingVersion>1.30.2</ANcpLuaRoslynUtilitiesTestingVersion>
<ANcpLuaRoslynUtilitiesTestingVersion>1.31.0</ANcpLuaRoslynUtilitiesTestingVersion>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and ensure these two package versions stay in sync, consider referencing the ANcpLuaRoslynUtilitiesVersion property here. Since ANcpLua.Roslyn.Utilities and ANcpLua.Roslyn.Utilities.Testing appear to be versioned together, this would prevent them from accidentally diverging in the future.

    <ANcpLuaRoslynUtilitiesTestingVersion>$(ANcpLuaRoslynUtilitiesVersion)</ANcpLuaRoslynUtilitiesTestingVersion>

</PropertyGroup>

<!-- ═══════════════════════════════════════════════════════════════════════
Expand Down