Fix RS1038 errors by downgrading Roslyn.Utilities to 1.28.0 in analyzers#47
Conversation
|
@claude implement |
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You're absolutely right! The issue was ANcpLua.Roslyn.Utilities 1.30.2 depending on Workspaces.Common, not CPM pinning. Fixed in commit The Workspaces packages are now completely removed from the analyzer dependency tree and RS1038 errors should be resolved. |
Two vectors caused Workspaces to leak into analyzer projects: 1. ANcpLua.Roslyn.Utilities transitively depends on Workspaces.Common 2. CSharp.Workspaces centrally defined + transitive pinning amplified it Fix: - Remove CSharp.Workspaces from central PackageVersion - Add ExcludeAssets="all" for Workspaces.Common in analyzer projects - Switch CodeFixes/Tests to VersionOverride for CSharp.Workspaces Upstream fix: ANcpLua/ANcpLua.Roslyn.Utilities#29 removes Workspaces from the core package entirely. Once published, these workarounds can be reverted and CSharp.Workspaces restored to central management. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
c52c28e to
1e33ef8
Compare
|
Closing in favor of the upstream fix: ANcpLua/ANcpLua.Roslyn.Utilities#29 removes Workspaces.Common from the core package entirely. Once 1.31.0 publishes, Analyzers just needs to update to the new version — no VersionOverride pins needed. |
Summary
Fix RS1038 CI failures (169 errors) caused by Microsoft.CodeAnalysis.Workspaces leaking into analyzer assemblies.
Root Cause
Two vectors:
Fix (this PR)
Upstream Fix
ANcpLua/ANcpLua.Roslyn.Utilities#29 moves CodeFixProviderBase from the core package to Testing, removing the Workspaces dependency entirely. Once published as 1.31.0, these workarounds can be reverted.
Test plan